Re: [PATCH v2 0/3] usbipd: enable tcp keepalive and set its options for accepted connection

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, May 23, 2025 at 12:07:22PM +0300, Vadym Hrynchyshyn wrote:
> If usbip client does not close a TCP/IP connection to a daemon
> gracefully, the daemon will keep this connection open indefinitely.
> 
> The issue is that the client cannot attach this device again
> until the device will be rebinded by commands:
> "usbip unbind -b ..." and "usbip bind -b ...".
> 
> This issue was reported by a user, look for details here 
> https://github.com/vadimgrn/usbip-win2/issues/109.
> 
> To reproduce this issue, run "usbip attach ..." to attach remote usb 
> device and make a hard reset of this PC by pressing Reset button.
> usbipd will keep this connection forever and will not allow to
> attach this device again until unbind/bind will be executed.
> 
> To fix that, enable SO_KEEPALIVE for accepted connection and set keepalive
> parameters if corresponding program options are passed.
> 
> Vadym Hrynchyshyn (3):
>   usbipd: enable SO_KEEPALIVE socket option for accepted connection
>   usbipd: add long options to set TCP_KEEPIDLE/TCP_KEEPCNT/TCP_KEEPINTVL
>     socket options
>   usbipd: use usbip_to_int to simplify usbip_setup_port_number
>     implementation
> 
>  tools/usb/usbip/configure.ac        | 24 +++++++-
>  tools/usb/usbip/src/usbip_network.c | 96 +++++++++++++++++++++++++----
>  tools/usb/usbip/src/usbip_network.h | 14 +++++
>  tools/usb/usbip/src/usbipd.c        | 58 +++++++++++++++--
>  4 files changed, 174 insertions(+), 18 deletions(-)
> 
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot