Re: [PATCH] usb: quirks: disable LPM for Xiaomi fastboot

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Thu, May 22, 2025 at 08:11:07PM +0000, Kampalus wrote:
> Both Xiaomi smartphones and AMD Ryzen systems have sketchy USB setups. When combined, fastboot
> fails to read and write data properly. Disabling Link Power Management works around that.
> 
> Despite only being useful for certain setups, let's enable this globally as it does
> not hurt healthy setups.
> 
> Signed-off-by: Kampalus <kampalus@protonmail.ch>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 13171454f..57f747776 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -552,6 +552,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> +	/* Xiaomi smartphones in fastboot mode */
> +	{ USB_DEVICE(0x18d1, 0xd00d), .driver_info = USB_QUIRK_NO_LPM },

Did you miss the comment at the top of this structure saying what order
this should be in?

Please fix.

Also, I need a "full" name for a patch to be accepted.

thanks,

greg k-h