* [PATCH] usb: quirks: disable LPM for Xiaomi fastboot
@ 2025-05-22 20:11 Kampalus
2025-05-23 4:28 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Kampalus @ 2025-05-22 20:11 UTC (permalink / raw)
To: linux-usb@vger.kernel.org; +Cc: gregkh@linuxfoundation.org
Both Xiaomi smartphones and AMD Ryzen systems have sketchy USB setups. When combined, fastboot
fails to read and write data properly. Disabling Link Power Management works around that.
Despite only being useful for certain setups, let's enable this globally as it does
not hurt healthy setups.
Signed-off-by: Kampalus <kampalus@protonmail.ch>
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 13171454f..57f747776 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -552,6 +552,9 @@ static const struct usb_device_id usb_quirk_list[] = {
/* INTEL VALUE SSD */
{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
+ /* Xiaomi smartphones in fastboot mode */
+ { USB_DEVICE(0x18d1, 0xd00d), .driver_info = USB_QUIRK_NO_LPM },
+
{ } /* terminating entry must be last */
};
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: quirks: disable LPM for Xiaomi fastboot
2025-05-22 20:11 [PATCH] usb: quirks: disable LPM for Xiaomi fastboot Kampalus
@ 2025-05-23 4:28 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2025-05-23 4:28 UTC (permalink / raw)
To: Kampalus; +Cc: linux-usb@vger.kernel.org
On Thu, May 22, 2025 at 08:11:07PM +0000, Kampalus wrote:
> Both Xiaomi smartphones and AMD Ryzen systems have sketchy USB setups. When combined, fastboot
> fails to read and write data properly. Disabling Link Power Management works around that.
>
> Despite only being useful for certain setups, let's enable this globally as it does
> not hurt healthy setups.
>
> Signed-off-by: Kampalus <kampalus@protonmail.ch>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 13171454f..57f747776 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -552,6 +552,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>
> + /* Xiaomi smartphones in fastboot mode */
> + { USB_DEVICE(0x18d1, 0xd00d), .driver_info = USB_QUIRK_NO_LPM },
Did you miss the comment at the top of this structure saying what order
this should be in?
Please fix.
Also, I need a "full" name for a patch to be accepted.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-23 4:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-22 20:11 [PATCH] usb: quirks: disable LPM for Xiaomi fastboot Kampalus
2025-05-23 4:28 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox