From: "Peter Chen (CIX)" <peter.chen@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: gregkh@linuxfoundation.org, shawnguo@kernel.org,
s.hauer@pengutronix.d, kernel@pengutronix.de, festevam@gmail.com,
jun.li@nxp.com, linux-usb@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] usb: chipidea: udc: add CI_HDRC_CONTROLLER_PULLUP_EVENT event
Date: Wed, 18 Jun 2025 18:35:30 +0800 [thread overview]
Message-ID: <20250618103530.GB34284@nchen-desktop> (raw)
In-Reply-To: <20250614125645.207732-2-xu.yang_2@nxp.com>
On 25-06-14 20:56:43, Xu Yang wrote:
> The device controller will send CI_HDRC_CONTROLLER_PULLUP_EVENT event
> when it's going to pullup or pulldown data line.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/chipidea/udc.c | 5 +++++
> include/linux/usb/chipidea.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 1a48e6440e6c..64a421ae0f05 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1970,6 +1970,11 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, int is_on)
> hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS);
> else
> hw_write(ci, OP_USBCMD, USBCMD_RS, 0);
> +
> + if (ci->platdata->notify_event) {
> + _gadget->connected = is_on;
> + ci->platdata->notify_event(ci, CI_HDRC_CONTROLLER_PULLUP_EVENT);
> + }
> pm_runtime_put_sync(ci->dev);
>
> return 0;
> diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h
> index ebdfef124b2b..e17ebeee24e3 100644
> --- a/include/linux/usb/chipidea.h
> +++ b/include/linux/usb/chipidea.h
> @@ -72,6 +72,7 @@ struct ci_hdrc_platform_data {
> #define CI_HDRC_IMX_HSIC_ACTIVE_EVENT 2
> #define CI_HDRC_IMX_HSIC_SUSPEND_EVENT 3
> #define CI_HDRC_CONTROLLER_VBUS_EVENT 4
> +#define CI_HDRC_CONTROLLER_PULLUP_EVENT 5
> int (*notify_event) (struct ci_hdrc *ci, unsigned event);
> struct regulator *reg_vbus;
> struct usb_otg_caps ci_otg_caps;
> --
> 2.34.1
>
--
Best regards,
Peter
next prev parent reply other threads:[~2025-06-18 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 12:56 [PATCH 0/3] implement workaround for ERR051725 Xu Yang
2025-06-14 12:56 ` [PATCH 1/3] usb: chipidea: udc: add CI_HDRC_CONTROLLER_PULLUP_EVENT event Xu Yang
2025-06-18 10:35 ` Peter Chen (CIX) [this message]
2025-06-14 12:56 ` [PATCH 2/3] usb: chipidea: imx: add imx_usbmisc_pullup() hook Xu Yang
2025-06-18 10:36 ` Peter Chen (CIX)
2025-06-14 12:56 ` [PATCH 3/3] usb: chipidea: imx: implement workaround for ERR051725 Xu Yang
2025-06-18 10:40 ` Peter Chen (CIX)
2025-06-17 8:19 ` [PATCH 0/3] " Peter Chen (CIX)
2025-06-18 6:06 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618103530.GB34284@nchen-desktop \
--to=peter.chen@kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.hauer@pengutronix.d \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox