* [PATCH] usb: dwc2: disable platform lowlevel hw resources during shutdown
@ 2025-06-29 9:46 Jisheng Zhang
2025-06-30 6:40 ` Minas Harutyunyan
0 siblings, 1 reply; 2+ messages in thread
From: Jisheng Zhang @ 2025-06-29 9:46 UTC (permalink / raw)
To: Minas Harutyunyan, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
On some SoC platforms, in shutdown stage, most components' power is cut
off, but there's still power supply to the so called always-on
domain, so if the dwc2's regulator is from the always-on domain, we
need to explicitly disable it to save power.
Disable platform lowlevel hw resources such as phy, clock and
regulators etc. in device shutdown hook to reduce non-necessary power
consumption when the platform enters shutdown stage.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/usb/dwc2/platform.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 12b4dc07d08a..3f83ecc9fc23 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -371,6 +371,9 @@ static void dwc2_driver_shutdown(struct platform_device *dev)
dwc2_disable_global_interrupts(hsotg);
synchronize_irq(hsotg->irq);
+
+ if (hsotg->ll_hw_enabled)
+ dwc2_lowlevel_hw_disable(hsotg);
}
/**
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc2: disable platform lowlevel hw resources during shutdown
2025-06-29 9:46 [PATCH] usb: dwc2: disable platform lowlevel hw resources during shutdown Jisheng Zhang
@ 2025-06-30 6:40 ` Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2025-06-30 6:40 UTC (permalink / raw)
To: Jisheng Zhang, Minas Harutyunyan, Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On 6/29/25 13:46, Jisheng Zhang wrote:
> On some SoC platforms, in shutdown stage, most components' power is cut
> off, but there's still power supply to the so called always-on
> domain, so if the dwc2's regulator is from the always-on domain, we
> need to explicitly disable it to save power.
>
> Disable platform lowlevel hw resources such as phy, clock and
> regulators etc. in device shutdown hook to reduce non-necessary power
> consumption when the platform enters shutdown stage.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/platform.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 12b4dc07d08a..3f83ecc9fc23 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -371,6 +371,9 @@ static void dwc2_driver_shutdown(struct platform_device *dev)
>
> dwc2_disable_global_interrupts(hsotg);
> synchronize_irq(hsotg->irq);
> +
> + if (hsotg->ll_hw_enabled)
> + dwc2_lowlevel_hw_disable(hsotg);
> }
>
> /**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-30 6:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-29 9:46 [PATCH] usb: dwc2: disable platform lowlevel hw resources during shutdown Jisheng Zhang
2025-06-30 6:40 ` Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox