From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, Lixu Zhang <lixu.zhang@intel.com>,
Hans de Goede <hansg@kernel.org>
Subject: Re: [PATCH 1/2] usb: ljca: Order ACPI hardware IDs alphabetically
Date: Mon, 13 Oct 2025 09:26:30 +0200 [thread overview]
Message-ID: <2025101353-unbeaten-kisser-6faf@gregkh> (raw)
In-Reply-To: <20251010055625.4147844-1-sakari.ailus@linux.intel.com>
On Fri, Oct 10, 2025 at 08:56:24AM +0300, Sakari Ailus wrote:
> The driver has three lists of ACPI hardware IDs, for GPIO, I²C and SPI.
> Order them alphabetically.
In the future, please say _why_ you need to do such a thing. The code
will work either way, and as Alan said, this will get out-of-order over
time :(
thanks,
greg k-h
prev parent reply other threads:[~2025-10-13 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 5:56 [PATCH 1/2] usb: ljca: Order ACPI hardware IDs alphabetically Sakari Ailus
2025-10-10 5:56 ` [PATCH 2/2] usb: ljca: Improve ACPI hardware ID documentation Sakari Ailus
2025-10-10 13:42 ` Hans de Goede
2025-10-10 13:42 ` [PATCH 1/2] usb: ljca: Order ACPI hardware IDs alphabetically Hans de Goede
2025-10-10 14:59 ` Alan Stern
2025-10-13 7:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025101353-unbeaten-kisser-6faf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox