Re: [PATCH 1/2] usb: ljca: Order ACPI hardware IDs alphabetically

[Hans de Goede <hansg@kernel.org>]

Hi,

On 10-Oct-25 7:56 AM, Sakari Ailus wrote:
> The driver has three lists of ACPI hardware IDs, for GPIO, I²C and SPI.
> Order them alphabetically.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Note 1 remark to maybe be addressed in a separate patch
below.



> ---
>  drivers/usb/misc/usb-ljca.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/misc/usb-ljca.c b/drivers/usb/misc/usb-ljca.c
> index c562630d862c..cf01cc727685 100644
> --- a/drivers/usb/misc/usb-ljca.c
> +++ b/drivers/usb/misc/usb-ljca.c
> @@ -165,26 +165,26 @@ struct ljca_match_ids_walk_data {
>  };
>  
>  static const struct acpi_device_id ljca_gpio_hids[] = {
> +	{ "INTC100B" },
>  	{ "INTC1074" },
>  	{ "INTC1096" },
> -	{ "INTC100B" },
> -	{ "INTC10D1" },
>  	{ "INTC10B5" },

This "INTC10B5" looks weird here, I don't think this actually
is in use. As can be seen by the matching "INTC10B6" HID
missing from ljca_i2c_hids[]. if we really needed "INTC10B5"
then I would expect "INTC10B6" to also be in the i2c list.

Regards,

Hans




> +	{ "INTC10D1" },
>  	{},
>  };
>  
>  static const struct acpi_device_id ljca_i2c_hids[] = {
> +	{ "INTC100C" },
>  	{ "INTC1075" },
>  	{ "INTC1097" },
> -	{ "INTC100C" },
>  	{ "INTC10D2" },
>  	{},
>  };
>  
>  static const struct acpi_device_id ljca_spi_hids[] = {
> +	{ "INTC100D" },
>  	{ "INTC1091" },
>  	{ "INTC1098" },
> -	{ "INTC100D" },
>  	{ "INTC10D3" },
>  	{},
>  };