* [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk.
@ 2025-10-14 15:30 Werner Sembach
2025-10-15 14:21 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Werner Sembach @ 2025-10-14 15:30 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tim Guttzeit, Werner Sembach, linux-usb, linux-kernel
From: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
The list of Huawei LTE modules needing the quirk fixing spurious wakeups
was missing the IDs of the Huawei ME906S module, therefore suspend did not
work.
Signed-off-by: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/usb/core/quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index f5bc538753301..39fbbc31e9a41 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -469,6 +469,8 @@ static const struct usb_device_id usb_quirk_list[] = {
USB_QUIRK_DISCONNECT_SUSPEND },
{ USB_DEVICE(0x12d1, 0x15c3), .driver_info =
USB_QUIRK_DISCONNECT_SUSPEND },
+ { USB_DEVICE(0x12d1, 0x15c1), .driver_info =
+ USB_QUIRK_DISCONNECT_SUSPEND },
/* SKYMEDI USB_DRIVE */
{ USB_DEVICE(0x1516, 0x8628), .driver_info = USB_QUIRK_RESET_RESUME },
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk.
2025-10-14 15:30 [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk Werner Sembach
@ 2025-10-15 14:21 ` Alan Stern
2025-10-15 15:48 ` Werner Sembach
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2025-10-15 14:21 UTC (permalink / raw)
To: Werner Sembach; +Cc: Greg Kroah-Hartman, Tim Guttzeit, linux-usb, linux-kernel
On Tue, Oct 14, 2025 at 05:30:05PM +0200, Werner Sembach wrote:
> From: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
>
> The list of Huawei LTE modules needing the quirk fixing spurious wakeups
> was missing the IDs of the Huawei ME906S module, therefore suspend did not
> work.
>
> Signed-off-by: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/usb/core/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index f5bc538753301..39fbbc31e9a41 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -469,6 +469,8 @@ static const struct usb_device_id usb_quirk_list[] = {
> USB_QUIRK_DISCONNECT_SUSPEND },
> { USB_DEVICE(0x12d1, 0x15c3), .driver_info =
> USB_QUIRK_DISCONNECT_SUSPEND },
> + { USB_DEVICE(0x12d1, 0x15c1), .driver_info =
> + USB_QUIRK_DISCONNECT_SUSPEND },
Please pay attention to the comment at the start of the array's
definition. Entries should be sorted by vendor ID and product ID.
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk.
2025-10-15 14:21 ` Alan Stern
@ 2025-10-15 15:48 ` Werner Sembach
0 siblings, 0 replies; 3+ messages in thread
From: Werner Sembach @ 2025-10-15 15:48 UTC (permalink / raw)
To: Alan Stern; +Cc: Greg Kroah-Hartman, Tim Guttzeit, linux-usb, linux-kernel
Hi,
Am 15.10.25 um 16:21 schrieb Alan Stern:
> On Tue, Oct 14, 2025 at 05:30:05PM +0200, Werner Sembach wrote:
>> From: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
>>
>> The list of Huawei LTE modules needing the quirk fixing spurious wakeups
>> was missing the IDs of the Huawei ME906S module, therefore suspend did not
>> work.
>>
>> Signed-off-by: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>> drivers/usb/core/quirks.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index f5bc538753301..39fbbc31e9a41 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -469,6 +469,8 @@ static const struct usb_device_id usb_quirk_list[] = {
>> USB_QUIRK_DISCONNECT_SUSPEND },
>> { USB_DEVICE(0x12d1, 0x15c3), .driver_info =
>> USB_QUIRK_DISCONNECT_SUSPEND },
>> + { USB_DEVICE(0x12d1, 0x15c1), .driver_info =
>> + USB_QUIRK_DISCONNECT_SUSPEND },
> Please pay attention to the comment at the start of the array's
> definition. Entries should be sorted by vendor ID and product ID.
Sorry for missing that, v2 incoming.
Best regards,
Werner
>
> Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-15 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 15:30 [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk Werner Sembach
2025-10-15 14:21 ` Alan Stern
2025-10-15 15:48 ` Werner Sembach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox