[PATCH] usb: musb: ux500: Fix PHY resource leak in error path

[PATCH] usb: musb: ux500: Fix PHY resource leak in error path

[Haotian Zhang]

The ux500_musb_init() function calls usb_get_phy() to obtain a PHY
resource, but fails to release it with usb_put_phy() when
usb_register_notifier() fails. This leads to a resource leak as the
PHY reference count is not properly decremented.

Add usb_put_phy() call in the error path before returning to ensure
the PHY resource is properly released when notifier registration fails.

Fixes: 0135522c4898 ("usb: musb: ux500: add otg notifier support")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 drivers/usb/musb/ux500.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 8c2a43d992f5..14c5e986937e 100644
--- a/drivers/usb/musb/ux500.c
+++ b/drivers/usb/musb/ux500.c
@@ -155,6 +155,7 @@ static int ux500_musb_init(struct musb *musb)
 	status = usb_register_notifier(musb->xceiv, &musb->nb);
 	if (status < 0) {
 		dev_dbg(musb->controller, "notification register failed\n");
+		usb_put_phy(musb->xceiv);
 		return status;
 	}
 
-- 
2.50.1.windows.1

Re: [PATCH] usb: musb: ux500: Fix PHY resource leak in error path

[Greg Kroah-Hartman]

On Mon, Nov 03, 2025 at 10:02:04AM +0800, Haotian Zhang wrote:
> The ux500_musb_init() function calls usb_get_phy() to obtain a PHY
> resource, but fails to release it with usb_put_phy() when
> usb_register_notifier() fails. This leads to a resource leak as the
> PHY reference count is not properly decremented.
> 
> Add usb_put_phy() call in the error path before returning to ensure
> the PHY resource is properly released when notifier registration fails.
> 
> Fixes: 0135522c4898 ("usb: musb: ux500: add otg notifier support")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
>  drivers/usb/musb/ux500.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> index 8c2a43d992f5..14c5e986937e 100644
> --- a/drivers/usb/musb/ux500.c
> +++ b/drivers/usb/musb/ux500.c
> @@ -155,6 +155,7 @@ static int ux500_musb_init(struct musb *musb)
>  	status = usb_register_notifier(musb->xceiv, &musb->nb);
>  	if (status < 0) {
>  		dev_dbg(musb->controller, "notification register failed\n");
> +		usb_put_phy(musb->xceiv);
>  		return status;
>  	}
>  
> -- 
> 2.50.1.windows.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot