public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: max77759: fix comment style for enums
@ 2026-04-01 21:02 Amit Sunil Dhamne via B4 Relay
  2026-04-23 12:07 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Amit Sunil Dhamne via B4 Relay @ 2026-04-01 21:02 UTC (permalink / raw)
  To: André Draszik, Lee Jones, Greg Kroah-Hartman
  Cc: linux-kernel, linux-usb, Badhri Jagan Sridharan,
	Amit Sunil Dhamne

From: Amit Sunil Dhamne <amitsd@google.com>

Fix comment style for enums so they're kernel-doc compliant.

Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
---
This patch is a follow-up to the series [1]. [1] has been accepted in
the USB subsystem tree (usb-next). However, since Lee has additional
feedback [2], I am sending this patch to fix it. Please note that this
patch is based out of usb-next branch on usb tree. This patch should be
applied on top of b422f7c072ac ("mfd: max77759: add register bitmasks
and modify irq configs for charger").

[1] https://lore.kernel.org/all/20260325-max77759-charger-v9-0-4486dd297adc@google.com/
[2] https://lore.kernel.org/all/20260331123138.GE3795166@google.com/
---
Output of kernel-doc script (none format)
$ scripts/kernel-doc -v -none -Wall include/linux/mfd/max77759.h
Info: include/linux/mfd/max77759.h:134 Scanning doc for enum max77759_chgr_chgin_dtls_status
Info: include/linux/mfd/max77759.h:152 Scanning doc for enum max77759_chgr_bat_dtls_states
Info: include/linux/mfd/max77759.h:174 Scanning doc for enum max77759_chgr_chg_dtls_states
Info: include/linux/mfd/max77759.h:212 Scanning doc for struct max77759
Info: include/linux/mfd/max77759.h:235 Scanning doc for struct max77759_maxq_command
Info: include/linux/mfd/max77759.h:247 Scanning doc for struct max77759_maxq_response
Info: include/linux/mfd/max77759.h:258 Scanning doc for function max77759_maxq_command
---
 include/linux/mfd/max77759.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/mfd/max77759.h b/include/linux/mfd/max77759.h
index ad1aa4c2b779..ec19be952877 100644
--- a/include/linux/mfd/max77759.h
+++ b/include/linux/mfd/max77759.h
@@ -131,12 +131,12 @@
 #define MAX77759_MAXQ_OPCODE_USER_SPACE_READ     0x81
 #define MAX77759_MAXQ_OPCODE_USER_SPACE_WRITE    0x82
 
-/*
+/**
  * enum max77759_chgr_chgin_dtls_status - Charger Input Status
  * @MAX77759_CHGR_CHGIN_DTLS_VBUS_UNDERVOLTAGE:
  *     Charger input voltage (Vchgin) < Under Voltage Threshold (Vuvlo)
- * @MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE: Vchgin > Vuvlo and
- *     Vchgin < (Battery Voltage (Vbatt) + system voltage (Vsys))
+ * @MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE:
+ *     Vchgin > Vuvlo and Vchgin < (Battery Voltage (Vbatt) + system voltage (Vsys))
  * @MAX77759_CHGR_CHGIN_DTLS_VBUS_OVERVOLTAGE:
  *     Vchgin > Over Voltage threshold (Vovlo)
  * @MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID:
@@ -149,7 +149,7 @@ enum max77759_chgr_chgin_dtls_status {
 	MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID,
 };
 
-/*
+/**
  * enum max77759_chgr_bat_dtls_states - Battery Details
  * @MAX77759_CHGR_BAT_DTLS_NO_BATT_CHG_SUSP:	No battery and the charger suspended
  * @MAX77759_CHGR_BAT_DTLS_DEAD_BATTERY:	Vbatt < Vtrickle
@@ -171,7 +171,7 @@ enum max77759_chgr_bat_dtls_states {
 	MAX77759_CHGR_BAT_DTLS_BAT_ONLY_MODE,
 };
 
-/*
+/**
  * enum max77759_chgr_chg_dtls_states - Charger Details
  * @MAX77759_CHGR_CHG_DTLS_PREQUAL:		Charger in prequalification mode
  * @MAX77759_CHGR_CHG_DTLS_CC:			Charger in fast charge const curr mode

---
base-commit: 81ebd43cc0d6d106ce7b6ccbf7b5e40ca7f5503d
change-id: 20260401-fix-mfd-max77759-usb-next-e687dd13c08a

Best regards,
-- 
Amit Sunil Dhamne <amitsd@google.com>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: max77759: fix comment style for enums
  2026-04-01 21:02 [PATCH] mfd: max77759: fix comment style for enums Amit Sunil Dhamne via B4 Relay
@ 2026-04-23 12:07 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2026-04-23 12:07 UTC (permalink / raw)
  To: amitsd
  Cc: André Draszik, Greg Kroah-Hartman, linux-kernel, linux-usb,
	Badhri Jagan Sridharan

On Wed, 01 Apr 2026, Amit Sunil Dhamne via B4 Relay wrote:

> From: Amit Sunil Dhamne <amitsd@google.com>
> 
> Fix comment style for enums so they're kernel-doc compliant.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> This patch is a follow-up to the series [1]. [1] has been accepted in
> the USB subsystem tree (usb-next). However, since Lee has additional
> feedback [2], I am sending this patch to fix it. Please note that this
> patch is based out of usb-next branch on usb tree. This patch should be
> applied on top of b422f7c072ac ("mfd: max77759: add register bitmasks
> and modify irq configs for charger").
> 
> [1] https://lore.kernel.org/all/20260325-max77759-charger-v9-0-4486dd297adc@google.com/
> [2] https://lore.kernel.org/all/20260331123138.GE3795166@google.com/
> ---
> Output of kernel-doc script (none format)
> $ scripts/kernel-doc -v -none -Wall include/linux/mfd/max77759.h
> Info: include/linux/mfd/max77759.h:134 Scanning doc for enum max77759_chgr_chgin_dtls_status
> Info: include/linux/mfd/max77759.h:152 Scanning doc for enum max77759_chgr_bat_dtls_states
> Info: include/linux/mfd/max77759.h:174 Scanning doc for enum max77759_chgr_chg_dtls_states
> Info: include/linux/mfd/max77759.h:212 Scanning doc for struct max77759
> Info: include/linux/mfd/max77759.h:235 Scanning doc for struct max77759_maxq_command
> Info: include/linux/mfd/max77759.h:247 Scanning doc for struct max77759_maxq_response
> Info: include/linux/mfd/max77759.h:258 Scanning doc for function max77759_maxq_command
> ---
>  include/linux/mfd/max77759.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Commit doesn't apply.  Please rebase.

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-23 12:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 21:02 [PATCH] mfd: max77759: fix comment style for enums Amit Sunil Dhamne via B4 Relay
2026-04-23 12:07 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox