* [PATCH 1/8] USB: serial: drop unused tty_driver includes
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 2/8] USB: serial: drop unused tty_flip includes Johan Hovold
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
USB serial drivers do not use anything from tty_driver.h directly (only
core does) so drop the unnecessary include directives.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/belkin_sa.c | 1 -
drivers/usb/serial/cyberjack.c | 1 -
drivers/usb/serial/cypress_m8.c | 1 -
drivers/usb/serial/digi_acceleport.c | 1 -
drivers/usb/serial/empeg.c | 1 -
drivers/usb/serial/f81232.c | 1 -
drivers/usb/serial/ftdi_sio.c | 1 -
drivers/usb/serial/garmin_gps.c | 1 -
drivers/usb/serial/io_edgeport.c | 1 -
drivers/usb/serial/io_ti.c | 1 -
drivers/usb/serial/ipaq.c | 1 -
drivers/usb/serial/ir-usb.c | 1 -
drivers/usb/serial/iuu_phoenix.c | 1 -
drivers/usb/serial/keyspan.c | 1 -
drivers/usb/serial/keyspan_pda.c | 1 -
drivers/usb/serial/kl5kusb105.c | 1 -
drivers/usb/serial/kobil_sct.c | 1 -
drivers/usb/serial/mct_u232.c | 1 -
drivers/usb/serial/metro-usb.c | 1 -
drivers/usb/serial/mos7720.c | 1 -
drivers/usb/serial/mos7840.c | 1 -
drivers/usb/serial/mxuport.c | 1 -
drivers/usb/serial/omninet.c | 1 -
drivers/usb/serial/opticon.c | 1 -
drivers/usb/serial/oti6858.c | 1 -
drivers/usb/serial/pl2303.c | 1 -
drivers/usb/serial/quatech2.c | 1 -
drivers/usb/serial/safe_serial.c | 1 -
drivers/usb/serial/spcp8x5.c | 1 -
drivers/usb/serial/ssu100.c | 1 -
drivers/usb/serial/symbolserial.c | 1 -
drivers/usb/serial/ti_usb_3410_5052.c | 1 -
drivers/usb/serial/visor.c | 1 -
drivers/usb/serial/whiteheat.c | 1 -
34 files changed, 34 deletions(-)
diff --git a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
index 38ac910b1082..adeb8e3441cf 100644
--- a/drivers/usb/serial/belkin_sa.c
+++ b/drivers/usb/serial/belkin_sa.c
@@ -23,7 +23,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/cyberjack.c b/drivers/usb/serial/cyberjack.c
index 4e8ceb23c27d..f457c8a65934 100644
--- a/drivers/usb/serial/cyberjack.c
+++ b/drivers/usb/serial/cyberjack.c
@@ -28,7 +28,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index afff1a0f4298..5322f4b3cce6 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -25,7 +25,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index d515df045c4c..85dbf87aa361 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -15,7 +15,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c
index aedcf7ebd269..a9f3d57236b2 100644
--- a/drivers/usb/serial/empeg.c
+++ b/drivers/usb/serial/empeg.c
@@ -16,7 +16,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 9262a2ac97f5..74b55fd9fd3f 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -11,7 +11,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index af14548fa03d..88dd32da82c2 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -31,7 +31,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 7205483a0115..6ab3ad7be7fc 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -15,7 +15,6 @@
#include <linux/slab.h>
#include <linux/timer.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
index 3f5889145e51..4cf77ead9334 100644
--- a/drivers/usb/serial/io_edgeport.c
+++ b/drivers/usb/serial/io_edgeport.c
@@ -30,7 +30,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index cb55370e036f..21a631d8e88f 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -18,7 +18,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index 3c6a9b9b9c2b..d9c9b78c41bd 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -10,7 +10,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c
index 12e928d25ba1..bda33a8976c7 100644
--- a/drivers/usb/serial/ir-usb.c
+++ b/drivers/usb/serial/ir-usb.c
@@ -25,7 +25,6 @@
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index 0ca111b111c7..6f2fd3a39d8e 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -14,7 +14,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 46448843541a..eb6e3d9d9ea7 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -29,7 +29,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index 5036600dd334..23a7683669eb 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -15,7 +15,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index ed8531a64768..64b7539043b1 100644
--- a/drivers/usb/serial/kl5kusb105.c
+++ b/drivers/usb/serial/kl5kusb105.c
@@ -35,7 +35,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/uaccess.h>
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index 6126afd67a7b..2be31d7a7e1f 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -23,7 +23,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 18844b92bd08..e009c2500a91 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -21,7 +21,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index bc834cc48550..45e370593d4c 100644
--- a/drivers/usb/serial/metro-usb.c
+++ b/drivers/usb/serial/metro-usb.c
@@ -13,7 +13,6 @@
#include <linux/usb.h>
#include <linux/errno.h>
#include <linux/slab.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 94459408e7fb..bc3b631041a9 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -21,7 +21,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index c0d0c24b074b..ef803e74ab4b 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -13,7 +13,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/serial.h>
diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c
index 591be1fe3737..8f7ff187dbf5 100644
--- a/drivers/usb/serial/mxuport.c
+++ b/drivers/usb/serial/mxuport.c
@@ -20,7 +20,6 @@
#include <linux/serial_reg.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/uaccess.h>
#include <linux/usb.h>
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index aa1e9745f967..3e44250dd360 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -14,7 +14,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/uaccess.h>
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index e2bed477ad57..b0c6e3578cf8 100644
--- a/drivers/usb/serial/opticon.c
+++ b/drivers/usb/serial/opticon.c
@@ -10,7 +10,6 @@
#include <linux/kernel.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/slab.h>
#include <linux/tty_flip.h>
#include <linux/serial.h>
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 3ef5b5d8ce1a..bb55bbb7ff25 100644
--- a/drivers/usb/serial/oti6858.c
+++ b/drivers/usb/serial/oti6858.c
@@ -38,7 +38,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 50dc838e8115..790c44c5d9b6 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -15,7 +15,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index b05c655b3cc4..fc94d6026a62 100644
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -13,7 +13,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/serial.h>
diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c
index 238b54993446..fa4128a0c933 100644
--- a/drivers/usb/serial/safe_serial.c
+++ b/drivers/usb/serial/safe_serial.c
@@ -64,7 +64,6 @@
#include <linux/errno.h>
#include <linux/gfp.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 2fbb48f19efd..5d5ea63da5df 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -14,7 +14,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index da6316410b77..09fb698d3d89 100644
--- a/drivers/usb/serial/ssu100.c
+++ b/drivers/usb/serial/ssu100.c
@@ -9,7 +9,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/serial.h>
diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c
index 7a5aa39172a8..c1f54248ecbb 100644
--- a/drivers/usb/serial/symbolserial.c
+++ b/drivers/usb/serial/symbolserial.c
@@ -10,7 +10,6 @@
#include <linux/kernel.h>
#include <linux/tty.h>
#include <linux/slab.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/usb.h>
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index b3591d6d7645..a68d91c548b9 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -18,7 +18,6 @@
#include <linux/firmware.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 062a38fe0c1c..8e1c7233ec45 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -15,7 +15,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 6e2b52b2b5f8..2487a4d81b98 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -16,7 +16,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/8] USB: serial: drop unused tty_flip includes
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
2026-05-11 7:14 ` [PATCH 1/8] USB: serial: drop unused tty_driver includes Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 3/8] USB: serial: xr: add missing uaccess include Johan Hovold
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
These drivers (and usb-serial.c) no longer use anything from tty_flip.h
directly so drop the unnecessary include directives.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/empeg.c | 1 -
drivers/usb/serial/ipaq.c | 1 -
drivers/usb/serial/ipw.c | 1 -
drivers/usb/serial/option.c | 1 -
drivers/usb/serial/qcserial.c | 1 -
drivers/usb/serial/spcp8x5.c | 1 -
drivers/usb/serial/usb-serial.c | 1 -
drivers/usb/serial/visor.c | 1 -
drivers/usb/serial/whiteheat.c | 1 -
9 files changed, 9 deletions(-)
diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c
index a9f3d57236b2..48e1a58ea3f5 100644
--- a/drivers/usb/serial/empeg.c
+++ b/drivers/usb/serial/empeg.c
@@ -16,7 +16,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/uaccess.h>
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index d9c9b78c41bd..eb9b7a7b1d14 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -10,7 +10,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/uaccess.h>
diff --git a/drivers/usb/serial/ipw.c b/drivers/usb/serial/ipw.c
index 83709d678b3a..b900d0317a71 100644
--- a/drivers/usb/serial/ipw.c
+++ b/drivers/usb/serial/ipw.c
@@ -36,7 +36,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 42e4cecd28ac..fd5f1d9ab2f2 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -32,7 +32,6 @@
#include <linux/jiffies.h>
#include <linux/errno.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/bitops.h>
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 1a930dc668e4..105c0a0eae86 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -8,7 +8,6 @@
*/
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 5d5ea63da5df..c11d64bf08fb 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -14,7 +14,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 0e072fd87c3d..67e880955ce7 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -22,7 +22,6 @@
#include <linux/slab.h>
#include <linux/tty.h>
#include <linux/tty_driver.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/seq_file.h>
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 8e1c7233ec45..06e30be10ca6 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -15,7 +15,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 2487a4d81b98..7ba05a1a3eae 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -16,7 +16,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty.h>
-#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/mutex.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/8] USB: serial: xr: add missing uaccess include
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
2026-05-11 7:14 ` [PATCH 1/8] USB: serial: drop unused tty_driver includes Johan Hovold
2026-05-11 7:14 ` [PATCH 2/8] USB: serial: drop unused tty_flip includes Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 4/8] USB: serial: drop unused uaccess includes Johan Hovold
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
Add the missing uaccess.h include, which is needed since TIOCSRS485
support was added, instead of relying on the header being included
indirectly.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/xr_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c
index 9fc4082de770..352c765d8803 100644
--- a/drivers/usb/serial/xr_serial.c
+++ b/drivers/usb/serial/xr_serial.c
@@ -16,6 +16,7 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/tty.h>
+#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/cdc.h>
#include <linux/usb/serial.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/8] USB: serial: drop unused uaccess includes
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (2 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 3/8] USB: serial: xr: add missing uaccess include Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 5/8] USB: serial: drop unused moduleparam includes Johan Hovold
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
These drivers (and usb-serial.c) no longer use anything from uaccess.h
directly so drop the unnecessary include directives.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/ark3116.c | 1 -
drivers/usb/serial/belkin_sa.c | 1 -
drivers/usb/serial/cyberjack.c | 1 -
drivers/usb/serial/cypress_m8.c | 1 -
drivers/usb/serial/digi_acceleport.c | 1 -
drivers/usb/serial/empeg.c | 1 -
drivers/usb/serial/f81232.c | 1 -
drivers/usb/serial/f81534.c | 1 -
drivers/usb/serial/garmin_gps.c | 1 -
drivers/usb/serial/generic.c | 1 -
drivers/usb/serial/io_ti.c | 1 -
drivers/usb/serial/ipaq.c | 1 -
drivers/usb/serial/ipw.c | 1 -
drivers/usb/serial/ir-usb.c | 1 -
drivers/usb/serial/iuu_phoenix.c | 1 -
drivers/usb/serial/keyspan.c | 1 -
drivers/usb/serial/keyspan_pda.c | 1 -
drivers/usb/serial/kl5kusb105.c | 1 -
drivers/usb/serial/kobil_sct.c | 1 -
drivers/usb/serial/mct_u232.c | 1 -
drivers/usb/serial/metro-usb.c | 1 -
drivers/usb/serial/mxuport.c | 1 -
drivers/usb/serial/omninet.c | 1 -
drivers/usb/serial/opticon.c | 1 -
drivers/usb/serial/oti6858.c | 1 -
drivers/usb/serial/pl2303.c | 1 -
drivers/usb/serial/quatech2.c | 1 -
drivers/usb/serial/safe_serial.c | 1 -
drivers/usb/serial/ssu100.c | 1 -
drivers/usb/serial/symbolserial.c | 1 -
drivers/usb/serial/ti_usb_3410_5052.c | 1 -
drivers/usb/serial/usb-serial.c | 1 -
drivers/usb/serial/usb_wwan.c | 1 -
drivers/usb/serial/visor.c | 1 -
drivers/usb/serial/whiteheat.c | 1 -
drivers/usb/serial/wishbone-serial.c | 1 -
drivers/usb/serial/xsens_mt.c | 1 -
37 files changed, 37 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index d974da43fba3..3a574b6ee0c4 100644
--- a/drivers/usb/serial/ark3116.c
+++ b/drivers/usb/serial/ark3116.c
@@ -28,7 +28,6 @@
#include <linux/usb/serial.h>
#include <linux/serial.h>
#include <linux/serial_reg.h>
-#include <linux/uaccess.h>
#include <linux/mutex.h>
#include <linux/spinlock.h>
diff --git a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
index adeb8e3441cf..36dcdb15d6ab 100644
--- a/drivers/usb/serial/belkin_sa.c
+++ b/drivers/usb/serial/belkin_sa.c
@@ -26,7 +26,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include "belkin_sa.h"
diff --git a/drivers/usb/serial/cyberjack.c b/drivers/usb/serial/cyberjack.c
index f457c8a65934..57e20eb02a46 100644
--- a/drivers/usb/serial/cyberjack.c
+++ b/drivers/usb/serial/cyberjack.c
@@ -31,7 +31,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 5322f4b3cce6..1d61968ab69a 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -34,7 +34,6 @@
#include <linux/serial.h>
#include <linux/kfifo.h>
#include <linux/delay.h>
-#include <linux/uaccess.h>
#include <linux/unaligned.h>
#include "cypress_m8.h"
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index 85dbf87aa361..a75813a57fbe 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -18,7 +18,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/wait.h>
#include <linux/sched/signal.h>
diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c
index 48e1a58ea3f5..4937575caff1 100644
--- a/drivers/usb/serial/empeg.c
+++ b/drivers/usb/serial/empeg.c
@@ -18,7 +18,6 @@
#include <linux/tty.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 74b55fd9fd3f..3a32f93a9738 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -16,7 +16,6 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/mutex.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/serial_reg.h>
diff --git a/drivers/usb/serial/f81534.c b/drivers/usb/serial/f81534.c
index 685930ac8383..0037767e4bbf 100644
--- a/drivers/usb/serial/f81534.c
+++ b/drivers/usb/serial/f81534.c
@@ -28,7 +28,6 @@
#include <linux/usb/serial.h>
#include <linux/serial_reg.h>
#include <linux/module.h>
-#include <linux/uaccess.h>
/* Serial Port register Address */
#define F81534_UART_BASE_ADDRESS 0x1200
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 6ab3ad7be7fc..9f955962d546 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -18,7 +18,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/atomic.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 757f0a586ddb..6eaf74930aa3 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -17,7 +17,6 @@
#include <linux/moduleparam.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#include <linux/kfifo.h>
#include <linux/serial.h>
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 21a631d8e88f..28e16515c7f1 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -27,7 +27,6 @@
#include <linux/kfifo.h>
#include <linux/ioctl.h>
#include <linux/firmware.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index eb9b7a7b1d14..c01bdbcb3f55 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -12,7 +12,6 @@
#include <linux/tty.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/ipw.c b/drivers/usb/serial/ipw.c
index b900d0317a71..5be153f2c68d 100644
--- a/drivers/usb/serial/ipw.c
+++ b/drivers/usb/serial/ipw.c
@@ -40,7 +40,6 @@
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#include "usb-wwan.h"
#define DRIVER_AUTHOR "Roelf Diedericks"
diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c
index bda33a8976c7..aac84539730d 100644
--- a/drivers/usb/serial/ir-usb.c
+++ b/drivers/usb/serial/ir-usb.c
@@ -28,7 +28,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/usb/irda.h>
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index 6f2fd3a39d8e..3b1f7546fb5c 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include "iuu_phoenix.h"
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index eb6e3d9d9ea7..4eea5ced2199 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -32,7 +32,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/usb/ezusb.h>
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index 23a7683669eb..3b99f9676c35 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/usb/ezusb.h>
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 64b7539043b1..e7917871ddf1 100644
--- a/drivers/usb/serial/kl5kusb105.c
+++ b/drivers/usb/serial/kl5kusb105.c
@@ -37,7 +37,6 @@
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
-#include <linux/uaccess.h>
#include <linux/unaligned.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index 2be31d7a7e1f..4a622cf8e6ae 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -26,7 +26,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/ioctl.h>
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index e009c2500a91..0e59289e7518 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -24,7 +24,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/unaligned.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index 45e370593d4c..5fcd89f57ef3 100644
--- a/drivers/usb/serial/metro-usb.c
+++ b/drivers/usb/serial/metro-usb.c
@@ -16,7 +16,6 @@
#include <linux/tty_flip.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb/serial.h>
#define DRIVER_DESC "Metrologic Instruments Inc. - USB-POS driver"
diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c
index 8f7ff187dbf5..9bdc5e2fee96 100644
--- a/drivers/usb/serial/mxuport.c
+++ b/drivers/usb/serial/mxuport.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/unaligned.h>
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 3e44250dd360..1f35a7e7654f 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -16,7 +16,6 @@
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/module.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index b0c6e3578cf8..152dfc901cd8 100644
--- a/drivers/usb/serial/opticon.c
+++ b/drivers/usb/serial/opticon.c
@@ -16,7 +16,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#define CONTROL_RTS 0x02
#define RESEND_CTS_STATE 0x03
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index bb55bbb7ff25..77f34d7651d6 100644
--- a/drivers/usb/serial/oti6858.c
+++ b/drivers/usb/serial/oti6858.c
@@ -45,7 +45,6 @@
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#include <linux/kfifo.h>
#include "oti6858.h"
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 790c44c5d9b6..128c80f11f49 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -20,7 +20,6 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/unaligned.h>
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index fc94d6026a62..dc2b39810a26 100644
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -19,7 +19,6 @@
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/serial_reg.h>
-#include <linux/uaccess.h>
/* default urb timeout for usb operations */
#define QT2_USB_TIMEOUT USB_CTRL_SET_TIMEOUT
diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c
index fa4128a0c933..a82b6453d79c 100644
--- a/drivers/usb/serial/safe_serial.c
+++ b/drivers/usb/serial/safe_serial.c
@@ -67,7 +67,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 09fb698d3d89..b0d51558b73c 100644
--- a/drivers/usb/serial/ssu100.c
+++ b/drivers/usb/serial/ssu100.c
@@ -15,7 +15,6 @@
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/serial_reg.h>
-#include <linux/uaccess.h>
#define QT_OPEN_CLOSE_CHANNEL 0xca
#define QT_SET_GET_DEVICE 0xc2
diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c
index c1f54248ecbb..8823671a9c7a 100644
--- a/drivers/usb/serial/symbolserial.c
+++ b/drivers/usb/serial/symbolserial.c
@@ -14,7 +14,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x05e0, 0x0600) },
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index a68d91c548b9..b3f00e315815 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -25,7 +25,6 @@
#include <linux/serial.h>
#include <linux/kfifo.h>
#include <linux/mutex.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 67e880955ce7..45e8a0b8d438 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -28,7 +28,6 @@
#include <linux/spinlock.h>
#include <linux/mutex.h>
#include <linux/list.h>
-#include <linux/uaccess.h>
#include <linux/serial.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
index e752ffa4dc62..a183cc4515ed 100644
--- a/drivers/usb/serial/usb_wwan.c
+++ b/drivers/usb/serial/usb_wwan.c
@@ -27,7 +27,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/bitops.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/cdc.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 06e30be10ca6..75f290a67cb4 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -18,7 +18,6 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/spinlock.h>
-#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
#include <linux/usb/cdc.h>
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 7ba05a1a3eae..106e9b5443d3 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/mutex.h>
-#include <linux/uaccess.h>
#include <asm/termbits.h>
#include <linux/usb.h>
#include <linux/serial_reg.h>
diff --git a/drivers/usb/serial/wishbone-serial.c b/drivers/usb/serial/wishbone-serial.c
index 670d573f6b63..4a1fed4cb57b 100644
--- a/drivers/usb/serial/wishbone-serial.c
+++ b/drivers/usb/serial/wishbone-serial.c
@@ -11,7 +11,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#define GSI_VENDOR_OPENCLOSE 0xB0
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index 382b3698c1d5..151a6e893ba2 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial/xsens_mt.c
@@ -10,7 +10,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
-#include <linux/uaccess.h>
#define XSENS_VID 0x2639
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/8] USB: serial: drop unused moduleparam includes
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (3 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 4/8] USB: serial: drop unused uaccess includes Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 6/8] USB: serial: garmin_gps: drop unused atomic include Johan Hovold
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
These drivers (and usb-serial.c) no longer use anything from
moduleparam.h so drop the unnecessary include directives.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/f81232.c | 1 -
drivers/usb/serial/metro-usb.c | 1 -
drivers/usb/serial/oti6858.c | 1 -
drivers/usb/serial/pl2303.c | 1 -
drivers/usb/serial/usb-serial.c | 1 -
drivers/usb/serial/visor.c | 1 -
6 files changed, 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 3a32f93a9738..dcceb95d7d99 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -14,7 +14,6 @@
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/mutex.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index 5fcd89f57ef3..35473544f1c8 100644
--- a/drivers/usb/serial/metro-usb.c
+++ b/drivers/usb/serial/metro-usb.c
@@ -14,7 +14,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/tty_flip.h>
-#include <linux/moduleparam.h>
#include <linux/spinlock.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 77f34d7651d6..c6364e8ff71f 100644
--- a/drivers/usb/serial/oti6858.c
+++ b/drivers/usb/serial/oti6858.c
@@ -41,7 +41,6 @@
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 128c80f11f49..0bcbdcea52af 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -18,7 +18,6 @@
#include <linux/tty_flip.h>
#include <linux/serial.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 45e8a0b8d438..17edc057a311 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -23,7 +23,6 @@
#include <linux/tty.h>
#include <linux/tty_driver.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/seq_file.h>
#include <linux/spinlock.h>
#include <linux/mutex.h>
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 75f290a67cb4..5706c46c49c2 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -16,7 +16,6 @@
#include <linux/slab.h>
#include <linux/tty.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/8] USB: serial: garmin_gps: drop unused atomic include
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (4 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 5/8] USB: serial: drop unused moduleparam includes Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 7/8] USB: serial: add missing atomic includes Johan Hovold
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
This driver no longer uses anything from atomic.h so drop the unused
include directive.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/garmin_gps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 9f955962d546..8020149f5658 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -18,7 +18,6 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/spinlock.h>
-#include <linux/atomic.h>
#include <linux/usb.h>
#include <linux/usb/serial.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/8] USB: serial: add missing atomic includes
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (5 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 6/8] USB: serial: garmin_gps: drop unused atomic include Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:14 ` [PATCH 8/8] USB: serial: whiteheat: drop termbits include Johan Hovold
2026-05-11 7:29 ` [PATCH 0/8] USB: serial: clean up include directives Greg Kroah-Hartman
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
Add the missing atomic.h include to the two driver that use it but did
not include it directly.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/io_edgeport.c | 1 +
drivers/usb/serial/mos7720.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
index 4cf77ead9334..34ccf7820537 100644
--- a/drivers/usb/serial/io_edgeport.c
+++ b/drivers/usb/serial/io_edgeport.c
@@ -25,6 +25,7 @@
*
*/
+#include <linux/atomic.h>
#include <linux/kernel.h>
#include <linux/jiffies.h>
#include <linux/errno.h>
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index bc3b631041a9..104f43a8f4d8 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -17,6 +17,8 @@
* Copyright (C) 2000 Inside Out Networks, All rights reserved.
* Copyright (C) 2001-2002 Greg Kroah-Hartman <greg@kroah.com>
*/
+
+#include <linux/atomic.h>
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/slab.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 8/8] USB: serial: whiteheat: drop termbits include
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (6 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 7/8] USB: serial: add missing atomic includes Johan Hovold
@ 2026-05-11 7:14 ` Johan Hovold
2026-05-11 7:29 ` [PATCH 0/8] USB: serial: clean up include directives Greg Kroah-Hartman
8 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2026-05-11 7:14 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
The termios definitions are provided by the termios.h header file which
is included by tty.h so drop the redundant asm/termbits.h include
directive.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/whiteheat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 106e9b5443d3..a2d83f69e00e 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/mutex.h>
-#include <asm/termbits.h>
#include <linux/usb.h>
#include <linux/serial_reg.h>
#include <linux/serial.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/8] USB: serial: clean up include directives
2026-05-11 7:14 [PATCH 0/8] USB: serial: clean up include directives Johan Hovold
` (7 preceding siblings ...)
2026-05-11 7:14 ` [PATCH 8/8] USB: serial: whiteheat: drop termbits include Johan Hovold
@ 2026-05-11 7:29 ` Greg Kroah-Hartman
8 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2026-05-11 7:29 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb, linux-kernel
On Mon, May 11, 2026 at 09:14:40AM +0200, Johan Hovold wrote:
> Include directives tend to be copied from existing drivers when new
> drivers are written. Clean up the driver include directives to avoid
> having to point out unnecessary includes when reviewing new drivers.
>
> Johan
>
>
> Johan Hovold (8):
> USB: serial: drop unused tty_driver includes
> USB: serial: drop unused tty_flip includes
> USB: serial: xr: add missing uaccess include
> USB: serial: drop unused uaccess includes
> USB: serial: drop unused moduleparam includes
> USB: serial: garmin_gps: drop unused atomic include
> USB: serial: add missing atomic includes
> USB: serial: whiteheat: drop termbits include
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 10+ messages in thread