From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeremy Erazo <mendozayt13@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: composite: fix integer underflow in WebUSB GET_URL handling
Date: Tue, 12 May 2026 07:39:29 +0200 [thread overview]
Message-ID: <2026051221-glory-macaroni-dce6@gregkh> (raw)
In-Reply-To: <20260512014343.3770664-1-mendozayt13@gmail.com>
On Tue, May 12, 2026 at 01:43:43AM +0000, Jeremy Erazo wrote:
> The WebUSB GET_URL handler in composite_setup() narrows
> landing_page_length to fit the host-supplied wLength using
>
> landing_page_length = w_length
> - WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH + landing_page_offset;
>
> If wLength is smaller than WEBUSB_URL_DESCRIPTOR_HEADER_LENGTH the
> unsigned subtraction wraps, and the subsequent
>
> memcpy(url_descriptor->URL,
> cdev->landing_page + landing_page_offset,
> landing_page_length - landing_page_offset);
>
> ends up copying close to UINT_MAX bytes from cdev->landing_page into
> cdev->req->buf. KASAN reports a slab-out-of-bounds in composite_setup
> on the kmalloc-2k gadget_info allocation, and FORTIFY_SOURCE traps the
> memcpy as a 4294967293-byte field-spanning write into
> url_descriptor->URL (size 252).
>
> A USB host can reach this from a single SETUP packet against any
> gadget that has webusb/use=1 and a landingPage configured.
>
> Handle the small-wLength case before the math: when the host requested
> fewer bytes than the URL descriptor header, only the header is
> meaningful and no URL bytes need to be copied. Setting
> landing_page_length to landing_page_offset makes the existing memcpy a
> no-op and leaves the descriptor returned to the host unchanged for all
> larger wLength values.
>
> Reported-by: Jeremy Erazo <mendozayt13@gmail.com>
> Signed-off-by: Jeremy Erazo <mendozayt13@gmail.com>
You don't need a reported-by when you are the author and sign off on
something.
What commit id does this fix? Why not backport it to stable kernels?
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-12 5:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 1:43 [PATCH] usb: gadget: composite: fix integer underflow in WebUSB GET_URL handling Jeremy Erazo
2026-05-12 5:39 ` Greg Kroah-Hartman [this message]
2026-05-12 11:18 ` Sebastian EM
2026-05-12 13:29 ` Greg Kroah-Hartman
[not found] ` <CAD89HyCWaa8esENsCip3foXe7c8x34HRx=37+c4MwnTpCbN1oQ@mail.gmail.com>
2026-05-12 14:32 ` Greg Kroah-Hartman
2026-05-12 15:38 ` [PATCH v2] " Jeremy Erazo
2026-05-12 15:48 ` Greg Kroah-Hartman
2026-05-12 16:05 ` [PATCH v3] " Jeremy Erazo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051221-glory-macaroni-dce6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mendozayt13@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox