From: Julian Braha <julianbraha@gmail.com>
To: b-liu@ti.com, gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Julian Braha <julianbraha@gmail.com>
Subject: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE
Date: Sat, 11 Jul 2026 14:03:49 +0100 [thread overview]
Message-ID: <20260711130349.592545-1-julianbraha@gmail.com> (raw)
'select' does not work on config options in a 'choice', so currently it is
possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
Replace 'select' with 'depends on'.
This dead select was found by kconfirm, a static analysis tool for Kconfig.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/usb/musb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f56929267eaa..f8ff2366f59f 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -116,7 +116,7 @@ config USB_MUSB_POLARFIRE_SOC
tristate "Microchip PolarFire SoC platforms"
depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
depends on NOP_USB_XCEIV
- select USB_MUSB_DUAL_ROLE
+ depends on USB_MUSB_DUAL_ROLE
help
Say Y here to enable support for USB on Microchip's PolarFire SoC.
--
2.54.0
next reply other threads:[~2026-07-11 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 13:03 Julian Braha [this message]
2026-07-11 14:39 ` [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE Arnd Bergmann
2026-07-11 15:09 ` Julian Braha
2026-07-12 21:56 ` Conor Dooley
2026-07-13 6:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711130349.592545-1-julianbraha@gmail.com \
--to=julianbraha@gmail.com \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox