From: Conor Dooley <conor@kernel.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
conor.dooley@microchip.com, daire.mcnamara@microchip.com,
valentina.fernandezalanis@microchip.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
claudiu.beznea@microchip.com,
Jassi Brar <jassisinghbrar@gmail.com>,
a.zummo@towertech.it,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
wsa@kernel.org, ben.dooks@codethink.co.uk,
heinrich.schuchardt@canonical.com
Subject: Re: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE
Date: Sun, 12 Jul 2026 22:56:39 +0100 [thread overview]
Message-ID: <20260712-parole-stoning-d7e66a0961a8@spud> (raw)
In-Reply-To: <1705e4f2-a0a3-4be0-a033-eacc1d54fcc7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Sat, Jul 11, 2026 at 04:09:58PM +0100, Julian Braha wrote:
> Hi Arnd,
>
> On 7/11/26 15:39, Arnd Bergmann wrote:
> > Good catch, but I wonder if this is actually a real dependency
> > at all. What would happen if you just remove the 'select' line
> > here and build a polarfire kernel that only supports
> > host or gadget mode but not dual-role?
>
> The kernel builds just fine for me with USB_MUSB_POLARFIRE_SOC=y and
> USB_MUSB_DUAL_ROLE=n
>
> But I don't have this hardware so I don't know what would happen at
> runtime.
>
> I've CC'd more people involved in patches to this config option.
This is the setup I've been using in my development environment for
(probably) years.
Probably the select should just be deleted.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-12 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 13:03 [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-11 14:39 ` Arnd Bergmann
2026-07-11 15:09 ` Julian Braha
2026-07-12 21:56 ` Conor Dooley [this message]
2026-07-13 6:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712-parole-stoning-d7e66a0961a8@spud \
--to=conor@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=jassisinghbrar@gmail.com \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox