From: Julian Braha <julianbraha@gmail.com>
To: b-liu@ti.com, gregkh@linuxfoundation.org
Cc: conor@kernel.org, arnd@arndb.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, daire.mcnamara@microchip.com,
valentina.fernandezalanis@microchip.com, mturquette@baylibre.com,
sboyd@kernel.org, claudiu.beznea@microchip.com,
jassisinghbrar@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, wsa@kernel.org,
ben.dooks@codethink.co.uk, heinrich.schuchardt@canonical.com,
Julian Braha <julianbraha@gmail.com>
Subject: [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
Date: Tue, 14 Jul 2026 12:20:47 +0100 [thread overview]
Message-ID: <20260714112047.2304856-2-julianbraha@gmail.com> (raw)
In-Reply-To: <20260714112047.2304856-1-julianbraha@gmail.com>
'select' does not work on config options in a 'choice', so currently it is
possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
Remove the dead select, as it is unnecessary, from this conversation:
https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/
This dead select was found by kconfirm, a static analysis tool for Kconfig.
Suggested-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1: remove 'select' instead of changing to dependency
Link: https://lore.kernel.org/all/20260711130349.592545-1-julianbraha@gmail.com/
drivers/usb/musb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f56929267eaa..1b0d27d8e02f 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -116,7 +116,6 @@ config USB_MUSB_POLARFIRE_SOC
tristate "Microchip PolarFire SoC platforms"
depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
depends on NOP_USB_XCEIV
- select USB_MUSB_DUAL_ROLE
help
Say Y here to enable support for USB on Microchip's PolarFire SoC.
--
2.54.0
next prev parent reply other threads:[~2026-07-14 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-14 11:20 ` Julian Braha [this message]
2026-07-14 11:57 ` Arnd Bergmann
2026-07-14 17:00 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714112047.2304856-2-julianbraha@gmail.com \
--to=julianbraha@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=claudiu.beznea@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox