From: "Arnd Bergmann" <arnd@arndb.de>
To: "Julian Braha" <julianbraha@gmail.com>, "Bin Liu" <b-liu@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Conor Dooley" <conor@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daire McNamara" <daire.mcnamara@microchip.com>,
valentina.fernandezalanis@microchip.com,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Ben Dooks" <ben.dooks@codethink.co.uk>,
"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE
Date: Tue, 14 Jul 2026 13:57:22 +0200 [thread overview]
Message-ID: <e40153b0-17ed-4261-9bff-8602902d0c2c@app.fastmail.com> (raw)
In-Reply-To: <20260714112047.2304856-1-julianbraha@gmail.com>
On Tue, Jul 14, 2026, at 13:20, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
>
> Remove the dead select, as it is unnecessary, from this conversation:
> https://lore.kernel.org/all/20260712-parole-stoning-d7e66a0961a8@spud/
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Suggested-by: Conor Dooley <conor@kernel.org>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2026-07-14 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 11:20 [PATCH v2] usb: musb: remove dead select of USB_MUSB_DUAL_ROLE Julian Braha
2026-07-14 11:20 ` Julian Braha
2026-07-14 11:57 ` Arnd Bergmann [this message]
2026-07-14 17:00 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40153b0-17ed-4261-9bff-8602902d0c2c@app.fastmail.com \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b-liu@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=claudiu.beznea@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=jassisinghbrar@gmail.com \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox