[PATCH] USB: serial: sierra: fix urb leak on write completion

[PATCH] USB: serial: sierra: fix urb leak on write completion

[Johan Hovold]

Make sure to drop the reference taken by usb_anchor_urb() also on
successful submission of delayed write URBs during runtime resume to
prevent them from leaking on completion.

Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
Reported-by: Wentao Liang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/20260916165352.2085480-1-vulab@iscas.ac.cn
Cc: stable@vger.kernel.org	# 2.6.32
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/sierra.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 6e443aacae07..f2cc7f364d20 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -972,12 +972,13 @@ static int sierra_submit_delayed_urbs(struct usb_serial_port *port)
 			intfdata->in_flight--;
 			usb_unanchor_urb(urb);
 			kfree(urb->transfer_buffer);
-			usb_free_urb(urb);
 
 			spin_lock(&portdata->lock);
 			portdata->outstanding_urbs--;
 			spin_unlock(&portdata->lock);
 		}
+
+		usb_put_urb(urb);
 	}
 
 	if (ec)
-- 
2.55.0

Re: [PATCH] USB: serial: sierra: fix urb leak on write completion

[sashiko-bot]

> Make sure to drop the reference taken by usb_anchor_urb() also on
> successful submission of delayed write URBs during runtime resume to
> prevent them from leaking on completion.
> 
> Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
> Reported-by: Wentao Liang <vulab@iscas.ac.cn>
> Link: https://lore.kernel.org/20260916165352.2085480-1-vulab@iscas.ac.cn
> Cc: stable@vger.kernel.org	# 2.6.32
> Cc: Oliver Neukum <oliver@neukum.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009123359.465071-1-johan@kernel.org?part=1

Re: [PATCH] USB: serial: sierra: fix urb leak on write completion

[Greg KH]

On Fri, Oct 09, 2026 at 02:33:59PM +0200, Johan Hovold wrote:
> Make sure to drop the reference taken by usb_anchor_urb() also on
> successful submission of delayed write URBs during runtime resume to
> prevent them from leaking on completion.
> 
> Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
> Reported-by: Wentao Liang <vulab@iscas.ac.cn>
> Link: https://lore.kernel.org/20260916165352.2085480-1-vulab@iscas.ac.cn
> Cc: stable@vger.kernel.org	# 2.6.32
> Cc: Oliver Neukum <oliver@neukum.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>