Re: [PATCH net v2] net: usb: aqc111: fix set_mac_address return value

[Simon Horman <horms@kernel.org>]

On Fri, Oct 16, 2026 at 08:48:58PM +0800, Hanson Wang wrote:
> aqc111_set_mac_addr() returns the result of aqc111_write_cmd() on
> success. That function wraps usb_control_msg(), which returns the
> number of bytes transferred (6 for ETH_ALEN) rather than zero.
> 
> Callers such as netif_set_mac_address() and bonding treat any
> non-zero return value as failure when setting the MAC address.
> 
> Return 0 on success and propagate negative error codes on failure.
> 
> Link: https://lore.kernel.org/netdev/20260703073936.462231-1-hanson.wang@ugreen.com
> 
> Signed-off-by: Hanson Wang <hanson.wang@ugreen.com>

Overall this looks good to me, thanks for your contribution.

Reviewed-by: Simon Horman <horms@kernel.org>

Some points on process to keep in mind.
There is no need to repost to address these.

1. Please respond to netdev-bot+sinfo.
   It's not too late to do so!

   https://lore.kernel.org/netdev/179215519735.408196.139629932849333374@kernel.org/

2. Please post new versions to patches in new email threads,
   not as a reply to an earlier versions.

3. Please don't repost within 24h.

4. Please don't repost the same version, without either
   incrementing the version number or including repost in the subject.

   [PATCh net v2 repost] ...

5. Please do include a summary of what has changed below the scissors ('---').
   Ideally including lore.kernel.org links to earlier versions.

   v2: Fixes indentation
   v1: https://lore.kernel.org/netdev/43a0904c-de59-4b40-b186-edd130f6c0cb@lunn.ch/

6. Please don't use the Link tag to link to an earlier version.
   Instead use it if there is some extra information,
   e.g. an otherwise unrelated email thread that lead to this patch.

For more information on Netdev processes please see
https://docs.kernel.org/process/maintainer-netdev.html