* Re: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2
[not found] <Wihw1vdISi-GVjWnM45KnA@gmail.com>
@ 2026-11-04 22:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-04 22:36 UTC (permalink / raw)
To: Adam Simonelli; +Cc: Johan Hovold, linux-usb, linux-kernel
On Wed, Nov 04, 2026 at 05:10:46PM -0500, Adam Simonelli wrote:
> >From fed0bc0868dd1e0dfe98ec84fcd7c1208cb076c3 Mon Sep 17 00:00:00 2001
> From: Adam Simonelli <adamsimonelli@gmail.com>
> Date: Wed, 4 Nov 2026 16:56:50 -0500
> Subject: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from
> the PalmUSBD.inf file in Palm Desktop 6.2
> ---
> drivers/usb/serial/visor.c | 6 ++++++
> drivers/usb/serial/visor.h | 4 ++++
> 2 files changed, 10 insertions(+)
> diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
> index 5706c46c49c2..5a289c566ba6 100644
> --- a/drivers/usb/serial/visor.c
> +++ b/drivers/usb/serial/visor.c
> @@ -75,6 +75,10 @@ static const struct usb_device_id id_table[] = {
> .driver_info = (kernel_ulong_t)&palm_os_4_probe },
> { USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID),
> .driver_info = (kernel_ulong_t)&palm_os_4_probe },
> + { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID),
> + .driver_info = (kernel_ulong_t)&palm_os_4_probe },
> + { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID),
> + .driver_info = (kernel_ulong_t)&palm_os_4_probe },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID),
> .driver_info = (kernel_ulong_t)&palm_os_4_probe },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID),
> @@ -133,6 +137,8 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(PALM_VENDOR_ID, PALM_TREO_650) },
> { USB_DEVICE(PALM_VENDOR_ID, PALM_TUNGSTEN_Z_ID) },
> { USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID) },
> + { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID) },
> + { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID) },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_3_5_ID) },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID) },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID) },
> diff --git a/drivers/usb/serial/visor.h b/drivers/usb/serial/visor.h
> index 622d639ce74e..0f86bd06c4fe 100644
> --- a/drivers/usb/serial/visor.h
> +++ b/drivers/usb/serial/visor.h
> @@ -32,6 +32,10 @@
> #define PALM_ZIRE_ID 0x0070
> #define PALM_M100_ID 0x0080
>
> +#define PALMSOURCE_VENDOR_ID 0x13e8
> +#define PALMSOURCE_DEVICE_1_ID 0x0600
> +#define PALMSOURCE_DEVICE_2_ID 0xff00
> +
> #define GSPDA_VENDOR_ID 0x115e
> #define GSPDA_XPLORE_M68_ID 0xf100
>
> --
> 2.55.0
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
and can not be applied. Please read the file,
Documentation/process/email-clients.rst in order to fix this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2
@ 2026-11-04 22:58 Adam Simonelli
2026-11-05 7:42 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Adam Simonelli @ 2026-11-04 22:58 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel
From fed0bc0868dd1e0dfe98ec84fcd7c1208cb076c3 Mon Sep 17 00:00:00 2001
From: Adam Simonelli <adamsimonelli@gmail.com>
Date: Wed, 4 Nov 2026 16:56:50 -0500
Subject: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from
the PalmUSBD.inf file in Palm Desktop 6.2
---
drivers/usb/serial/visor.c | 6 ++++++
drivers/usb/serial/visor.h | 4 ++++
2 files changed, 10 insertions(+)
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 5706c46c49c2..5a289c566ba6 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -75,6 +75,10 @@ static const struct usb_device_id id_table[] = {
.driver_info = (kernel_ulong_t)&palm_os_4_probe },
{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID),
.driver_info = (kernel_ulong_t)&palm_os_4_probe },
+ { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID),
+ .driver_info = (kernel_ulong_t)&palm_os_4_probe },
+ { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID),
+ .driver_info = (kernel_ulong_t)&palm_os_4_probe },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID),
.driver_info = (kernel_ulong_t)&palm_os_4_probe },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID),
@@ -133,6 +137,8 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE(PALM_VENDOR_ID, PALM_TREO_650) },
{ USB_DEVICE(PALM_VENDOR_ID, PALM_TUNGSTEN_Z_ID) },
{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID) },
+ { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID) },
+ { USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_3_5_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID) },
diff --git a/drivers/usb/serial/visor.h b/drivers/usb/serial/visor.h
index 622d639ce74e..0f86bd06c4fe 100644
--- a/drivers/usb/serial/visor.h
+++ b/drivers/usb/serial/visor.h
@@ -32,6 +32,10 @@
#define PALM_ZIRE_ID 0x0070
#define PALM_M100_ID 0x0080
+#define PALMSOURCE_VENDOR_ID 0x13e8
+#define PALMSOURCE_DEVICE_1_ID 0x0600
+#define PALMSOURCE_DEVICE_2_ID 0xff00
+
#define GSPDA_VENDOR_ID 0x115e
#define GSPDA_XPLORE_M68_ID 0xf100
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2
2026-11-04 22:58 Adam Simonelli
@ 2026-11-05 7:42 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2026-11-05 7:42 UTC (permalink / raw)
To: Adam Simonelli; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Wed, Nov 04, 2026 at 05:58:24PM -0500, Adam Simonelli wrote:
> From fed0bc0868dd1e0dfe98ec84fcd7c1208cb076c3 Mon Sep 17 00:00:00 2001
> From: Adam Simonelli <adamsimonelli@gmail.com>
> Date: Wed, 4 Nov 2026 16:56:50 -0500
> Subject: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from
> the PalmUSBD.inf file in Palm Desktop 6.2
> ---
This patch is still corrupted and cannot be applied. You are also
missing a commit message and a Signed-off by tag.
Try sending the patch to yourself first and run checkpatch on it and try
to apply it with git am after you receive it to make sure your setup
works before posting another version to the list.
git-format-patch and git-send-email are useful tools for sending
patches.
See
Documentation/process/submitting-patches.rst
and perhaps also
Documentation/process/email-clients.rst
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-05 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Wihw1vdISi-GVjWnM45KnA@gmail.com>
2026-11-04 22:36 ` [PATCH] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2 Greg Kroah-Hartman
2026-11-04 22:58 Adam Simonelli
2026-11-05 7:42 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox