From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Arisa Snowbell <arisa.snowbell@gmail.com>,
linux-usb@vger.kernel.org, regressions@lists.linux.dev,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: Re: [PATCH usb-next] usb: xhci-pci: Cleanup xhci_pci_setup() for shared HCD
Date: Mon, 13 Oct 2025 10:55:54 +0300 [thread overview]
Message-ID: <21741b98-4844-4218-8bd9-10b8bf5cd869@linux.intel.com> (raw)
In-Reply-To: <20251013092250.699bf60f.michal.pecio@gmail.com>
On 10/13/25 10:22, Michal Pecio wrote:
> This function will be called again when/if the shared HCD is added.
> Little to do in this case and there is no need to set some de-facto
> read-only properties of the xhci again, even if it was harmless.
>
> Don't bother passing the unused xhci_pci_quirks in this case either.
>
> Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> ---
>
> This is an alternative to the cleanup discussed last week, which
> doesn't require a v2 bugfix. But I also have a v2 bugfix ready if
> you think the original option was better.
>
Can I get both :)
A v2 targeted bugfix that I can send now to 6.18-rc, tested by Arisa,
making sure the regression is fixed.
Then this improvement on top of that, which we can send to 6.19 after
it has been sitting in next kernel for a while, making sure there are
no new surprises
Thanks
Mathias
next prev parent reply other threads:[~2025-10-13 7:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 20:47 [REGRESSION] USB-A devices not working on boot after recent USB merge Arisa Snowbell
2025-10-07 21:17 ` Michal Pecio
2025-10-07 22:30 ` Arisa Snowbell
2025-10-08 1:15 ` Arisa Snowbell
2025-10-08 1:41 ` Arisa Snowbell
2025-10-08 6:20 ` Michal Pecio
2025-10-08 9:02 ` Arisa Snowbell
2025-10-08 11:05 ` Michal Pecio
2025-10-08 12:16 ` Arisa Snowbell
2025-10-08 20:34 ` Michal Pecio
2025-10-08 21:29 ` Arisa Snowbell
2025-10-08 22:25 ` Arisa Snowbell
2025-10-09 11:14 ` [REGRESSION] [REPRO] " Michal Pecio
2025-10-09 11:30 ` Mathias Nyman
2025-10-09 13:27 ` Michal Pecio
2025-10-10 8:15 ` Mathias Nyman
2025-10-10 9:15 ` Arisa Snowbell
2025-10-13 7:22 ` [PATCH usb-next] usb: xhci-pci: Cleanup xhci_pci_setup() for shared HCD Michal Pecio
2025-10-13 7:55 ` Mathias Nyman [this message]
2025-10-13 8:04 ` [PATCH v2 RFT] usb: xhci-pci: Fix USB2-only root hub registration Michal Pecio
2025-10-13 13:52 ` Arisa Snowbell
2025-10-13 14:33 ` Hanabishi
2025-10-13 16:03 ` Michal Kubecek
2025-11-14 14:06 ` [PATCH] usb: xhci-pci: Clean up xhci_pci_setup() Michal Pecio
2025-10-09 12:16 ` [REGRESSION] [REPRO] USB-A devices not working on boot after recent USB merge Arisa Snowbell
2025-10-09 12:29 ` [PATCH] usb: xhci-pci: Fix USB2-only root hub registration Michal Pecio
2025-10-09 12:49 ` Arisa Snowbell
2025-10-09 13:08 ` Mathias Nyman
2025-10-09 11:15 ` [REGRESSION] USB-A devices not working on boot after recent USB merge Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21741b98-4844-4218-8bd9-10b8bf5cd869@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=arisa.snowbell@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=niklas.neronin@linux.intel.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox