From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Arisa Snowbell <arisa.snowbell@gmail.com>,
linux-usb@vger.kernel.org, regressions@lists.linux.dev,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: Re: [REGRESSION] [REPRO] USB-A devices not working on boot after recent USB merge
Date: Fri, 10 Oct 2025 11:15:55 +0300 [thread overview]
Message-ID: <b8c2423f-aa9d-442a-ae2f-3c4d78949b38@linux.intel.com> (raw)
In-Reply-To: <20251009152703.72e780b4.michal.pecio@gmail.com>
On 10/9/25 16:27, Michal Pecio wrote:
> On Thu, 9 Oct 2025 14:30:20 +0300, Mathias Nyman wrote:
>> Maybe the xhci->allow_single_roothub = 1; flag could be set in xhci_pci_setup()
>> when called for primary hcd
>
> Oops, I put it at the beginning so it is now executing twice on
> two-speed controllers.
>
> I only understood this remark when I saw my confirmation printk()
> appearing twice after removing the "hide USB3 ports" hack.
>
>
> Should I do a v2 or leave cleaning it up for later?
> I suspect that imod_interval should also be moved a few lines down.
I'll happily take a v2 instead if Arisa has time to test it.
You're right about the imod_interval as well, but that is a minor cleanup
for a separate usb-next patch.
Thanks
Mathias
next prev parent reply other threads:[~2025-10-10 8:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 20:47 [REGRESSION] USB-A devices not working on boot after recent USB merge Arisa Snowbell
2025-10-07 21:17 ` Michal Pecio
2025-10-07 22:30 ` Arisa Snowbell
2025-10-08 1:15 ` Arisa Snowbell
2025-10-08 1:41 ` Arisa Snowbell
2025-10-08 6:20 ` Michal Pecio
2025-10-08 9:02 ` Arisa Snowbell
2025-10-08 11:05 ` Michal Pecio
2025-10-08 12:16 ` Arisa Snowbell
2025-10-08 20:34 ` Michal Pecio
2025-10-08 21:29 ` Arisa Snowbell
2025-10-08 22:25 ` Arisa Snowbell
2025-10-09 11:14 ` [REGRESSION] [REPRO] " Michal Pecio
2025-10-09 11:30 ` Mathias Nyman
2025-10-09 13:27 ` Michal Pecio
2025-10-10 8:15 ` Mathias Nyman [this message]
2025-10-10 9:15 ` Arisa Snowbell
2025-10-13 7:22 ` [PATCH usb-next] usb: xhci-pci: Cleanup xhci_pci_setup() for shared HCD Michal Pecio
2025-10-13 7:55 ` Mathias Nyman
2025-10-13 8:04 ` [PATCH v2 RFT] usb: xhci-pci: Fix USB2-only root hub registration Michal Pecio
2025-10-13 13:52 ` Arisa Snowbell
2025-10-13 14:33 ` Hanabishi
2025-10-13 16:03 ` Michal Kubecek
2025-11-14 14:06 ` [PATCH] usb: xhci-pci: Clean up xhci_pci_setup() Michal Pecio
2025-10-09 12:16 ` [REGRESSION] [REPRO] USB-A devices not working on boot after recent USB merge Arisa Snowbell
2025-10-09 12:29 ` [PATCH] usb: xhci-pci: Fix USB2-only root hub registration Michal Pecio
2025-10-09 12:49 ` Arisa Snowbell
2025-10-09 13:08 ` Mathias Nyman
2025-10-09 11:15 ` [REGRESSION] USB-A devices not working on boot after recent USB merge Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c2423f-aa9d-442a-ae2f-3c4d78949b38@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=arisa.snowbell@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=niklas.neronin@linux.intel.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox