Linux USB
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, Sean Anderson <sean.anderson@seco.com>
Subject: Re: usb-next tree has patch applied twice
Date: Thu, 22 Feb 2024 14:46:46 +0100	[thread overview]
Message-ID: <22194332.EfDdHjke4D@steina-w> (raw)
In-Reply-To: <2024022254-tiptop-sublease-6357@gregkh>

Am Donnerstag, 22. Februar 2024, 14:06:12 CET schrieb Greg Kroah-Hartman:
> On Thu, Feb 22, 2024 at 11:16:59AM +0100, Alexander Stein wrote:
> > Hi,
> > 
> > CC'ing Sean as well.
> > 
> > Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
> > > On Tue, Feb 20, 2024 at 04:29:04PM +0100, Alexander Stein wrote:
> > > > Hi Greg,
> > > > 
> > > > on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply
> > > > has been applied twice:
> > > > * 03e607cbb2931374db1825f371e9c7f28526d3f4
> > > 
> > > This is from the 5.18 release, from this email series:
> > > 	https://lore.kernel.org/all/20220425171412.1188485-3-sean.anderson@seco.com/
> > > from 2022.
> > > 
> > > > * 75fd6485cccef269ac9eb3b71cf56753341195ef
> > > 
> > > This is from a newer series:
> > > 	https://lore.kernel.org/all/20240123225111.1629405-3-sean.anderson@seco.com/
> > > that I applied from there.
> > > 
> > > So how did it apply cleanly twice?
> > 
> > Apparently the series from 2024 is v3 from the older v2 one. For some reason
> > only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the
> > apply went unnoticed but the patch is again part of the series :(
> > 
> > > > causing my board imx8mm-tqma8mqml-mba8mx.dts failing to probe USB phy:
> > > > [   11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator
> > > > [   11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1
> > > > 
> > > > Reverting/removing the patch fix my problem.
> > > 
> > > Which patch?  All of the ones in that last series?  If so, why did it
> > > apply at all?
> > 
> > In my case I reverted 75fd6485cccef269ac9eb3b71cf56753341195ef from
> > usb-next, because that very change has been applied with
> > 03e607cbb2931374db1825f371e9c7f28526d3f4 already.
> 
> Can you send a patch that resolves this all properly?

Which tree shall this patch apply to? usb-next?
Shall it revert 03e607cbb2931374db1825f371e9c7f28526d3f4 from v5.18
or 75fd6485cccef269ac9eb3b71cf56753341195ef from usb-next?

Thanks,
Alexander

> thanks,
> 
> greg k-h
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



  reply	other threads:[~2024-02-22 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 15:29 usb-next tree has patch applied twice Alexander Stein
2024-02-22  7:47 ` Greg Kroah-Hartman
2024-02-22 10:16   ` Alexander Stein
2024-02-22 13:06     ` Greg Kroah-Hartman
2024-02-22 13:46       ` Alexander Stein [this message]
2024-02-22 14:05         ` Greg Kroah-Hartman
2024-02-22 16:08           ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22194332.EfDdHjke4D@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox