Linux USB
 help / color / mirror / Atom feed
From: Alberto Mattea <alberto@mattea.info>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
Date: Mon, 17 Feb 2020 17:46:46 +0100	[thread overview]
Message-ID: <2527163.mvXUDI8C0e@alby> (raw)
In-Reply-To: <20200217163018.GD1502885@kroah.com>

In data lunedì 17 febbraio 2020 17:30:18 CET, Greg KH ha scritto:
> On Mon, Feb 17, 2020 at 05:07:17PM +0100, Alberto Mattea wrote:
> > In data lunedì 17 febbraio 2020 16:45:38 CET, hai scritto:
> > > On Mon, Feb 17, 2020 at 04:21:50PM +0100, Alberto Mattea wrote:
> > > > Fixes suspend/resume
> > > 
> > > We are going to need a lot more information here, sorry.  Please be
> > > explicit as to what you are doing and why.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > Sure, what about
> > "This controller timeouts during suspend (S3) with 
> > [  240.521724] xhci_hcd 0000:30:00.3: WARN: xHC save state timeout
> > [  240.521729] xhci_hcd 0000:30:00.3: ERROR mismatched command completion event
> > thus preventing the system from entering S3. Moreover it remains in an undefined state
> > where some connected devices stop working until a reboot.
> > Apply the XHCI_SUSPEND_DELAY quirk to make it suspend properly."
> 
> I sure beats the original 3 words you wrote :)
> 
> 

Great, I'll fix the commit and resend the patch :)



      reply	other threads:[~2020-02-17 19:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 15:21 [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c Alberto Mattea
2020-02-17 15:45 ` Greg KH
2020-02-17 16:07   ` Alberto Mattea
2020-02-17 16:30     ` Greg KH
2020-02-17 16:46       ` Alberto Mattea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2527163.mvXUDI8C0e@alby \
    --to=alberto@mattea.info \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox