* [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
@ 2020-02-17 15:21 Alberto Mattea
2020-02-17 15:45 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alberto Mattea @ 2020-02-17 15:21 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb
Fixes suspend/resume
Signed-off-by: Alberto Mattea <alberto@mattea.info>
---
drivers/usb/host/xhci-pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 4917c5b033fa..1533310b3d6b 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -135,7 +135,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
xhci->quirks |= XHCI_AMD_PLL_FIX;
if (pdev->vendor == PCI_VENDOR_ID_AMD &&
- (pdev->device == 0x15e0 ||
+ (pdev->device == 0x145c ||
+ pdev->device == 0x15e0 ||
pdev->device == 0x15e1 ||
pdev->device == 0x43bb))
xhci->quirks |= XHCI_SUSPEND_DELAY;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
2020-02-17 15:21 [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c Alberto Mattea
@ 2020-02-17 15:45 ` Greg KH
2020-02-17 16:07 ` Alberto Mattea
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-02-17 15:45 UTC (permalink / raw)
To: Alberto Mattea; +Cc: linux-usb
On Mon, Feb 17, 2020 at 04:21:50PM +0100, Alberto Mattea wrote:
> Fixes suspend/resume
We are going to need a lot more information here, sorry. Please be
explicit as to what you are doing and why.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
2020-02-17 15:45 ` Greg KH
@ 2020-02-17 16:07 ` Alberto Mattea
2020-02-17 16:30 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alberto Mattea @ 2020-02-17 16:07 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb
In data lunedì 17 febbraio 2020 16:45:38 CET, hai scritto:
> On Mon, Feb 17, 2020 at 04:21:50PM +0100, Alberto Mattea wrote:
> > Fixes suspend/resume
>
> We are going to need a lot more information here, sorry. Please be
> explicit as to what you are doing and why.
>
> thanks,
>
> greg k-h
>
Sure, what about
"This controller timeouts during suspend (S3) with
[ 240.521724] xhci_hcd 0000:30:00.3: WARN: xHC save state timeout
[ 240.521729] xhci_hcd 0000:30:00.3: ERROR mismatched command completion event
thus preventing the system from entering S3. Moreover it remains in an undefined state
where some connected devices stop working until a reboot.
Apply the XHCI_SUSPEND_DELAY quirk to make it suspend properly."
Thanks,
Alberto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
2020-02-17 16:07 ` Alberto Mattea
@ 2020-02-17 16:30 ` Greg KH
2020-02-17 16:46 ` Alberto Mattea
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-02-17 16:30 UTC (permalink / raw)
To: Alberto Mattea; +Cc: linux-usb
On Mon, Feb 17, 2020 at 05:07:17PM +0100, Alberto Mattea wrote:
> In data lunedì 17 febbraio 2020 16:45:38 CET, hai scritto:
> > On Mon, Feb 17, 2020 at 04:21:50PM +0100, Alberto Mattea wrote:
> > > Fixes suspend/resume
> >
> > We are going to need a lot more information here, sorry. Please be
> > explicit as to what you are doing and why.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Sure, what about
> "This controller timeouts during suspend (S3) with
> [ 240.521724] xhci_hcd 0000:30:00.3: WARN: xHC save state timeout
> [ 240.521729] xhci_hcd 0000:30:00.3: ERROR mismatched command completion event
> thus preventing the system from entering S3. Moreover it remains in an undefined state
> where some connected devices stop working until a reboot.
> Apply the XHCI_SUSPEND_DELAY quirk to make it suspend properly."
I sure beats the original 3 words you wrote :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c
2020-02-17 16:30 ` Greg KH
@ 2020-02-17 16:46 ` Alberto Mattea
0 siblings, 0 replies; 5+ messages in thread
From: Alberto Mattea @ 2020-02-17 16:46 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb
In data lunedì 17 febbraio 2020 17:30:18 CET, Greg KH ha scritto:
> On Mon, Feb 17, 2020 at 05:07:17PM +0100, Alberto Mattea wrote:
> > In data lunedì 17 febbraio 2020 16:45:38 CET, hai scritto:
> > > On Mon, Feb 17, 2020 at 04:21:50PM +0100, Alberto Mattea wrote:
> > > > Fixes suspend/resume
> > >
> > > We are going to need a lot more information here, sorry. Please be
> > > explicit as to what you are doing and why.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > Sure, what about
> > "This controller timeouts during suspend (S3) with
> > [ 240.521724] xhci_hcd 0000:30:00.3: WARN: xHC save state timeout
> > [ 240.521729] xhci_hcd 0000:30:00.3: ERROR mismatched command completion event
> > thus preventing the system from entering S3. Moreover it remains in an undefined state
> > where some connected devices stop working until a reboot.
> > Apply the XHCI_SUSPEND_DELAY quirk to make it suspend properly."
>
> I sure beats the original 3 words you wrote :)
>
>
Great, I'll fix the commit and resend the patch :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-17 19:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-17 15:21 [PATCH] usb: xhci: apply XHCI_SUSPEND_DELAY to AMD XHCI controller 1022:145c Alberto Mattea
2020-02-17 15:45 ` Greg KH
2020-02-17 16:07 ` Alberto Mattea
2020-02-17 16:30 ` Greg KH
2020-02-17 16:46 ` Alberto Mattea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox