public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Alban Browaeys <alban.browaeys@gmail.com>
To: Oliver Neukum <oneukum@suse.com>, linux-usb@vger.kernel.org
Subject: Re: add NO_REPORT_LUNS quirk for at least a few Seagate external drives to fix smartctl with uas
Date: Wed, 12 Jun 2024 03:39:56 +0200	[thread overview]
Message-ID: <25ee57cfbe5c2ab6522ae4e0992f68c4c9a70766.camel@gmail.com> (raw)
In-Reply-To: <48c94250-64b3-4a19-9c87-0f48a2ceb425@suse.com>

Le mardi 11 juin 2024 à 10:21 +0200, Oliver Neukum a écrit :
> 
> 
> On 10.06.24 21:25, Alban Browaeys wrote:
> > I found that for "smartctl" to work on my two Seagate Expansion
> > external USB3  I had to add the "j" usb-storage quirks ie
> > "US_FL_NO_REPORT_LUNS".
> > (They are years apart).
> 
> Hi,
> 
> does the attached patch do the job?
> 
> 	Regards
> 		Oliver

No, it does not work.
smartctl is still broken with the US_FL_NO_REPORT_LUNS in
drivers/usb/storage/unusual_uas.h.

But if I add back the "j" usb.quirks flag back with:
echo -n "0x0bc2:0x2037:j" | sudo tee  /sys/module/usb_storage/parameters/quirks
and then:
echo -n "2-2:1.0" | sudo tee /sys/bus/usb/drivers/uas/unbind
echo -n "2-2:1.0" | sudo tee /sys/bus/usb/drivers/uas/bind
then smartctl works.

I tested on tw kernels with the two different seagate drives.

sudo grep Seagate /sys/devices/ -r |& grep Seagate
/sys/devices/pci0000:00/0000:00:14.0/usb2/2-2/manufacturer:Seagate
/sys/devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/host8/target8:0:0/8:0:0:0/vendor:Seagate

head /sys/devices/pci0000\:00/0000\:00\:14.0/usb2/2-2/quirks 
0x0

 


lrwxrwxrwx 1 root root  9 12 juin  03:14 usb-
Seagate_Expansion_HDD_00000000NACSHZWL-0:0 -> ../../sdc
lrwxrwxrwx 1 root root 10 12 juin  03:14 usb-Seagate_Expansion_HDD_00000000NACSHZWL-0:0-part1 -> ../../sdc1

sudo smartctl -i /dev/sdc
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.10.0-rc3+] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

Read Device Identity failed: scsi error unsupported field in scsi command

If this is a USB connected device, look at the various --device=TYPE variants
A mandatory SMART command failed: exiting. To continue, add one or more '-T permissive' options.


lsusb -t
/:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=xhci_hcd/12p, 480M
    |__ Port 001: Dev 002, If 0, Class=Vendor Specific Class, Driver=[none], 12M
    |__ Port 001: Dev 002, If 1, Class=Audio, Driver=[none], 12M
    |__ Port 001: Dev 002, If 2, Class=Audio, Driver=[none], 12M
    |__ Port 005: Dev 003, If 0, Class=Hub, Driver=hub/4p, 480M
        |__ Port 002: Dev 005, If 0, Class=Vendor Specific Class, Driver=cp210x, 12M
        |__ Port 003: Dev 008, If 0, Class=Wireless, Driver=btusb, 12M
        |__ Port 003: Dev 008, If 1, Class=Wireless, Driver=btusb, 12M
    |__ Port 009: Dev 004, If 0, Class=Hub, Driver=hub/4p, 480M
        |__ Port 003: Dev 009, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
        |__ Port 003: Dev 009, If 1, Class=Human Interface Device, Driver=usbhid, 1.5M
        |__ Port 004: Dev 010, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
        |__ Port 004: Dev 010, If 1, Class=Human Interface Device, Driver=usbhid, 1.5M
/:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=xhci_hcd/6p, 5000M
    |__ Port 002: Dev 002, If 0, Class=Mass Storage, Driver=uas, 5000M
    |__ Port 003: Dev 003, If 0, Class=Mass Storage, Driver=usb-storage, 5000M
    |__ Port 005: Dev 004, If 0, Class=Hub, Driver=hub/4p, 5000M
    |__ Port 006: Dev 005, If 0, Class=Mass Storage, Driver=usb-storage, 5000M

with the "j" usb.quirks flag:
sudo smartctl -i /dev/sdc
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.10.0-rc3+] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke,
www.smartmontools.org

=== START OF INFORMATION SECTION ===
Model Family:     Seagate Barracuda 2.5 5400
Device Model:     ST4000LM024-2AN17V
Serial Number:    WCKAEWZZ
LU WWN Device Id: 5 000c50 0e732b6d8
Firmware Version: 0001
User Capacity:    4 000 787 030 016 bytes [4,00 TB]
Sector Sizes:     512 bytes logical, 4096 bytes physical
Rotation Rate:    5526 rpm
Form Factor:      2.5 inches
Device is:        In smartctl database 7.3/5528
ATA Version is:   ACS-3 T13/2161-D revision 5
SATA Version is:  SATA 3.1, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is:    Wed Jun 12 03:30:47 2024 CEST
SMART support is: Available - device has SMART capability.
SMART support is: Enabled



Regards,
Alban

  reply	other threads:[~2024-06-12  1:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 19:25 add NO_REPORT_LUNS quirk for at least a few Seagate external drives to fix smartctl with uas Alban Browaeys
2024-06-11  6:08 ` Greg KH
2024-06-11  8:21 ` Oliver Neukum
2024-06-12  1:39   ` Alban Browaeys [this message]
2024-06-12 15:13     ` Alban Browaeys
2024-06-14  0:18       ` Alban Browaeys
2024-06-14  1:20         ` Remove NO_ATA_1X quirk for at least a few Seagate external drives to fix smartctl with uas ? Alban Browaeys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ee57cfbe5c2ab6522ae4e0992f68c4c9a70766.camel@gmail.com \
    --to=alban.browaeys@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox