From: Oliver Neukum <oneukum@suse.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling
Date: Wed, 8 Jul 2026 14:57:42 +0200 [thread overview]
Message-ID: <2a0bacab-951a-48b2-8263-bad3088a29b7@suse.com> (raw)
In-Reply-To: <20260708-dev-mctp-usb-1-1-v3-4-9e710155cdbf@codeconstruct.com.au>
On 08.07.26 11:58, Jeremy Kerr wrote:
Hi,
> @@ -198,6 +254,8 @@ static int mctp_usb_open(struct net_device *dev)
> struct mctp_usb *mctp_usb = netdev_priv(dev);
>
> WRITE_ONCE(mctp_usb->rx_stopped, false);
> + mctp_usb->clear_halt = false;
> + mctp_usb->in_err_count = 0;
What allows the assumption that mctp_usb_open() does not race
with error handling? What happens if the device is still stalled?
It seems to me that you need to wait for the halt to be cleared.
Regards
Oliver
next prev parent reply other threads:[~2026-07-08 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 9:58 [PATCH net-next v3 00/12] net: mctp: usb: Add support for MCTP-over-USB v1.1 Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 01/12] net: mctp: usb: Include version indicator in max packet size defines Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 02/12] net: mctp: usb: Use packet-length max for maximum packet-size check Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 03/12] net: mctp: usblib: Move RX transfer processing to a new mctp-usblib Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling Jeremy Kerr
2026-07-08 12:57 ` Oliver Neukum [this message]
2026-07-09 3:12 ` Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 05/12] net: mctp: usblib: Move TX transfer processing to mctp-usblib Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 06/12] net: mctp: usblib: Add support for multi-packet transmit Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 07/12] net: mctp: usb: Accommodate DSP0283 v1.1 header format Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 08/12] net: mctp: usblib: Implement receive-side packet spanning Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 09/12] net: mctp: usblib: Implement transmit-side " Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 10/12] net: mctp: usblib: Add initial kunit tests Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 11/12] net: mctp: usb: enable v1.1 packet spanning Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 12/12] net: mctp: usb: Allow multiple urbs in flight Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0bacab-951a-48b2-8263-bad3088a29b7@suse.com \
--to=oneukum@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox