From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Oliver Neukum <oneukum@suse.com>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling
Date: Thu, 09 Jul 2026 11:12:49 +0800 [thread overview]
Message-ID: <aa92796bc2dce8098c5e8174b163f1949a748c58.camel@codeconstruct.com.au> (raw)
In-Reply-To: <2a0bacab-951a-48b2-8263-bad3088a29b7@suse.com>
Hi Oliver,
Thanks for taking a look.
> What allows the assumption that mctp_usb_open() does not race
> with error handling? What happens if the device is still stalled?
When ndo_open is called, we know that the delayed rx work (which
performs the usb_clear_halt) has been quiesced, so aren't racing with
the actual recovery.
The device may still be stalled; that should be okay though, as we'll
detect that through the subsequent IN urb submission, which will re-set
->clear halt and schedule the rx work to do the clear.
Unless I have missed a case there?
Cheers,
Jeremy
next prev parent reply other threads:[~2026-07-09 3:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 9:58 [PATCH net-next v3 00/12] net: mctp: usb: Add support for MCTP-over-USB v1.1 Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 01/12] net: mctp: usb: Include version indicator in max packet size defines Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 02/12] net: mctp: usb: Use packet-length max for maximum packet-size check Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 03/12] net: mctp: usblib: Move RX transfer processing to a new mctp-usblib Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 04/12] net: mctp: usb: Improve IN endpoint status handling Jeremy Kerr
2026-07-08 12:57 ` Oliver Neukum
2026-07-09 3:12 ` Jeremy Kerr [this message]
2026-07-08 9:58 ` [PATCH net-next v3 05/12] net: mctp: usblib: Move TX transfer processing to mctp-usblib Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 06/12] net: mctp: usblib: Add support for multi-packet transmit Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 07/12] net: mctp: usb: Accommodate DSP0283 v1.1 header format Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 08/12] net: mctp: usblib: Implement receive-side packet spanning Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 09/12] net: mctp: usblib: Implement transmit-side " Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 10/12] net: mctp: usblib: Add initial kunit tests Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 11/12] net: mctp: usb: enable v1.1 packet spanning Jeremy Kerr
2026-07-08 9:58 ` [PATCH net-next v3 12/12] net: mctp: usb: Allow multiple urbs in flight Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa92796bc2dce8098c5e8174b163f1949a748c58.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox