From: neil.armstrong@linaro.org
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, mturquette@baylibre.com, vkoul@kernel.org,
kishon@kernel.org, hminas@synopsys.com,
Thinh.Nguyen@synopsys.com, yue.wang@amlogic.com,
hanjie.lin@amlogic.com, kernel@sberdevices.ru,
rockosov@gmail.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v1 4/5] usb: dwc3-meson-g12a: support OTG switch
Date: Mon, 17 Apr 2023 14:22:26 +0200 [thread overview]
Message-ID: <3381d124-1049-16da-bcdb-1cbbec379154@linaro.org> (raw)
In-Reply-To: <20230417114739.r7aoiodqybalbn4o@CAB-WSD-L081021>
On 17/04/2023 13:47, Dmitry Rokosov wrote:
> Hello Martin,
>
> Thank you for quick review, appreciate it!
> Please find my comments below and in the other replies.
>
> On Sun, Apr 16, 2023 at 10:56:36PM +0200, Martin Blumenstingl wrote:
>> On Fri, Apr 14, 2023 at 5:24 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
>> [...]
>>> static const struct dwc3_meson_g12a_drvdata a1_drvdata = {
>>> - .otg_switch_supported = false,
>>> + .otg_switch_supported = true,
>> it would be great if you could also follow up with a patch that
>> removes otg_switch_supported.
>> A1 was the only variant that needed it and after this patch it's just dead code.
>
> It makes sense. I thought about it before sending the first version, but
> I found a counter-argument: future SoCs may use this parameter.
> But if you ask, I will remove 'otg_switch_supported' in the next version
>
Please remove it, it's easy to add it again if needed.
Neil
next prev parent reply other threads:[~2023-04-17 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 15:24 [PATCH v1 0/5] arm64: meson: support Amlogic A1 USB OTG controller Dmitry Rokosov
2023-04-14 15:24 ` [PATCH v1 1/5] phy: amlogic: during USB PHY clkin obtaining, enable it Dmitry Rokosov
2023-04-16 20:54 ` Martin Blumenstingl
2023-04-17 11:57 ` Dmitry Rokosov
2023-04-14 15:24 ` [PATCH v1 2/5] usb: dwc2: support dwc2 IP for Amlogic A1 SoC family Dmitry Rokosov
2023-04-14 15:24 ` [PATCH v1 3/5] dt-bindings: usb: dwc2: add support for Amlogic A1 SoC USB peripheral Dmitry Rokosov
2023-04-14 15:24 ` [PATCH v1 4/5] usb: dwc3-meson-g12a: support OTG switch Dmitry Rokosov
2023-04-16 20:56 ` Martin Blumenstingl
2023-04-17 11:47 ` Dmitry Rokosov
2023-04-17 12:22 ` neil.armstrong [this message]
2023-04-17 12:29 ` Dmitry Rokosov
2023-04-14 15:24 ` [PATCH v1 5/5] arm64: dts: meson: a1: support USB controller in OTG mode Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3381d124-1049-16da-bcdb-1cbbec379154@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjie.lin@amlogic.com \
--cc=hminas@synopsys.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=vkoul@kernel.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox