Linux USB
 help / color / mirror / Atom feed
* [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
@ 2026-10-11 16:42 Olivier Kaloudoff
  2026-10-11 16:47 ` sashiko-bot
  0 siblings, 1 reply; 11+ messages in thread
From: Olivier Kaloudoff @ 2026-10-11 16:42 UTC (permalink / raw)
  To: linux-usb; +Cc: hdegoede, stern, Olivier Kaloudoff

The ASMedia chip detection in uas_use_uas_driver() assumes that every
device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
config.MaxPower of 0 is an ASM1153 with working UAS.

Newer ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa
id and also report MaxPower == 0, so they take the "ASM1153, do
nothing" path — but their UAS implementation is broken:

- The first READ(16) issued by sd probing times out after 30 s;
  enumeration only completes after a uas_eh_abort_handler plus a full
  uas_eh_host_reset_handler cycle:

    scsi 3:0:0:0: Direct-Access  ASMT  ASMT135x  0  PQ: 0 ANSI: 6
    sd 3:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD IN
    sd 3:0:0:0: [sdb] tag#26 CDB: Read(16) 88 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00
    scsi host3: uas_eh_host_reset_handler start
    usb 6-2: reset SuperSpeed USB device number 2 using xhci_hcd
    scsi host3: uas_eh_host_reset_handler success

- Under concurrent load the bridge stalls: all inflight commands (20+
  UAS tags in the captured incident, mixed READ(16)/WRITE(16)) hit the
  30 s UAS timeout in the same event, forcing repeated abort/reset
  cycles and eventually a USB disconnect.  Writes dropped mid-flight
  during these resets returned zeros to the filesystem (observed as
  XFS metadata corruption on the mounted volume).

- Sequential-write throughput is ~45 MiB/s under UAS versus ~136 MiB/s
  after disabling UAS (usb-storage BOT mode), which is fully stable:
  several tens of GiB written without a single error.

- Bulk reads of healthy LBA ranges do work under UAS (~190 MiB/s, no
  errors); the failure pattern is command-timeout at enumeration and
  under queue depth / write load, not a broken transfer path.

Since 174c:55aa is shared across several ASMedia bridges and enclosure
rebrandings, distinguish the ASMT135x by the product string — the same
approach used for the HIKSEMI MD202 check a few lines below.  The
product strings of working ASM1053/ASM1153 devices ("ASM1053E",
"ASM1153", "ASM1153E", vendor rebrands such as "YZWY_TECH") do not
contain "135", so matching the ASMT135x family string is safe.

Verified on an ORICO enclosure (iManufacturer "ASMT", iProduct
"ASMT135x", bcdDevice 1.00) attached through an Alpine Ridge TB3 dock:
with the equivalent usb-storage quirks parameter (174c:55aa:u) the
device is completely stable.

Reported-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>
Signed-off-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>
---
 drivers/usb/storage/uas-detect.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

lsusb -v output for the affected device (Bus 006) and a second
174c:55aa bridge on the same host (Bus 010, "YZWY_TECH", unaffected):

Couldn't open device, some information will be missing

Bus 006 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
Negotiated speed: SuperSpeed (5Gbps)
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.20
  bDeviceClass            0 [unknown]
  bDeviceSubClass         0 [unknown]
  bDeviceProtocol         0 
  bMaxPacketSize0         9
  idVendor           0x174c ASMedia Technology Inc.
  idProduct          0x55aa ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
  bcdDevice            1.00
  iManufacturer           2 ASMT
  iProduct                3 ASMT135x
  iSerial                 1 123456789053
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength       0x0079
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0xc0
      Self Powered
    MaxPower                0mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       1
      bNumEndpoints           4
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98 USB Attached SCSI
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-in pipe (0x03)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-out pipe (0x04)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Status pipe (0x02)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorTCouldn't open device, some information will be missing
ype         5
        bEndpointAddress     0x04  EP 4 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
        Command pipe (0x01)

Bus 010 Device 003: ID 174c:55aa ASMedia Technology Inc. ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
Negotiated speed: SuperSpeed (5Gbps)
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.00
  bDeviceClass            0 [unknown]
  bDeviceSubClass         0 [unknown]
  bDeviceProtocol         0 
  bMaxPacketSize0         9
  idVendor           0x174c ASMedia Technology Inc.
  idProduct          0x55aa ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
  bcdDevice            1.00
  iManufacturer           2 Min Yi USB Device  
  iProduct                3 YZWY_TECH
  iSerial                 1 123456789020
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength       0x0079
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0xc0
      Self Powered
    MaxPower                0mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       1
      bNumEndpoints           4
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98 USB Attached SCSI
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-in pipe (0x03)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-out pipe (0x04)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Status pipe (0x02)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x04  EP 4 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
        Command pipe (0x01)

diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
index 0000000..0000000 100644
--- a/drivers/usb/storage/uas-detect.h
+++ b/drivers/usb/storage/uas-detect.h
@@ -99,7 +99,17 @@
 			(le16_to_cpu(udev->descriptor.idProduct) == 0x5106 ||
 			 le16_to_cpu(udev->descriptor.idProduct) == 0x55aa)) {
 		if (udev->actconfig->desc.bMaxPower == 0) {
-			/* ASM1153, do nothing */
+			/*
+			 * ASMT135x bridges share this signature but hang
+			 * under UAS: commands stall until the 30 s UAS
+			 * timeout, already during device probing, and a
+			 * queue of inflight commands wedges the bridge
+			 * entirely.  Identify them by product string,
+			 * same as the MD202 check below.
+			 */
+			if (udev->product && strstr(udev->product, "135"))
+				flags |= US_FL_IGNORE_UAS;
+			/* else ASM1153, do nothing */
 		} else if (udev->speed < USB_SPEED_SUPER) {
 			/* No streams info, assume ASM1051 */
 			flags |= US_FL_IGNORE_UAS;
-- 
2.43.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-10-11 16:42 Olivier Kaloudoff
@ 2026-10-11 16:47 ` sashiko-bot
  0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-11 16:47 UTC (permalink / raw)
  To: Olivier Kaloudoff; +Cc: linux-usb

> The ASMedia chip detection in uas_use_uas_driver() assumes that every
> device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
> config.MaxPower of 0 is an ASM1153 with working UAS.
> 
> Newer ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa
> id and also report MaxPower == 0, so they take the "ASM1153, do
> nothing" path — but their UAS implementation is broken:
> 
> - The first READ(16) issued by sd probing times out after 30 s;
>   enumeration only completes after a uas_eh_abort_handler plus a full
>   uas_eh_host_reset_handler cycle:
> 
>     scsi 3:0:0:0: Direct-Access  ASMT  ASMT135x  0  PQ: 0 ANSI: 6
>     sd 3:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD IN
>     sd 3:0:0:0: [sdb] tag#26 CDB: Read(16) 88 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00
> [ ... ]
> with the equivalent usb-storage quirks parameter (174c:55aa:u) the
> device is completely stable.
> 
> Reported-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>
> Signed-off-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011164259.30572-1-olivier.kaloudoff@gmail.com?part=1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
@ 2026-10-13 22:19 Olivier Kaloudoff
  2026-10-13 22:23 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Olivier Kaloudoff @ 2026-10-13 22:19 UTC (permalink / raw)
  To: linux-usb; +Cc: stern, gregkh, usb-storage, Olivier Kaloudoff, stable

The ASMedia chip detection in uas_use_uas_driver() assumes that every
device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
config.MaxPower of 0 is an ASM1153 with working UAS.

ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa id and
also report MaxPower == 0, so they take the "ASM1153, do nothing"
path — but their UAS implementation is broken:

- The first READ(16) issued by sd probing times out after 30 s;
  enumeration only completes after a uas_eh_abort_handler plus a full
  uas_eh_host_reset_handler cycle:

    scsi 3:0:0:0: Direct-Access  ASMT  ASMT135x  0  PQ: 0 ANSI: 6
    sd 3:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD IN
    sd 3:0:0:0: [sdb] tag#26 CDB: Read(16) 88 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00
    scsi host3: uas_eh_host_reset_handler start
    usb 6-2: reset SuperSpeed USB device number 2 using xhci_hcd
    scsi host3: uas_eh_host_reset_handler success

- Under concurrent load the bridge stalls: all inflight commands (20+
  UAS tags in the captured incident, mixed READ(16)/WRITE(16)) hit the
  30 s UAS timeout in the same event, forcing repeated abort/reset
  cycles and eventually a USB disconnect.  Writes dropped mid-flight
  during these resets returned zeros to the filesystem (observed as
  XFS metadata corruption on the mounted volume).

- Sequential-write throughput is ~45 MiB/s under UAS versus ~136 MiB/s
  after disabling UAS (usb-storage BOT mode), which is fully stable:
  several tens of GiB written without a single error.

- Bulk reads of healthy LBA ranges do work under UAS (~190 MiB/s, no
  errors); the failure pattern is command-timeout at enumeration and
  under queue depth / write load, not a broken transfer path.

Since 174c:55aa is shared across several ASMedia bridges and enclosure
rebrandings, distinguish the ASMT135x by its product string — the same
approach used for the HIKSEMI MD202 check a few lines below.  The
product strings of working bridges using the same id ("ASM1053E",
"ASM1153", "ASM1153E", "ASM1351", vendor rebrands such as "YZWY_TECH")
do not contain "ASMT135", so the match is safe.

Verified on an ORICO enclosure (iManufacturer "ASMT", iProduct
"ASMT135x", bcdDevice 1.00) attached through an Alpine Ridge TB3 dock:
with the equivalent usb-storage quirks parameter (174c:55aa:u) the
device is completely stable.

Cc: stable@vger.kernel.org
Signed-off-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>
---
lsusb -v for the affected ASMT135x bridge (Bus 006 Dev 002) and the
second, unaffected 174c:55aa bridge on the same host (Bus 010,
iProduct "YZWY_TECH", keeps working UAS):

Couldn't open device, some information will be missing

Bus 006 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
Negotiated speed: SuperSpeed (5Gbps)
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.20
  bDeviceClass            0 [unknown]
  bDeviceSubClass         0 [unknown]
  bDeviceProtocol         0 
  bMaxPacketSize0         9
  idVendor           0x174c ASMedia Technology Inc.
  idProduct          0x55aa ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
  bcdDevice            1.00
  iManufacturer           2 ASMT
  iProduct                3 ASMT135x
  iSerial                 1 123456789053
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength       0x0079
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0xc0
      Self Powered
    MaxPower                0mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       1
      bNumEndpoints           4
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98 USB Attached SCSI
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-in pipe (0x03)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-out pipe (0x04)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Status pipe (0x02)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorTCouldn't open device, some information will be missing
ype         5
        bEndpointAddress     0x04  EP 4 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
        Command pipe (0x01)

Bus 010 Device 003: ID 174c:55aa ASMedia Technology Inc. ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
Negotiated speed: SuperSpeed (5Gbps)
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.00
  bDeviceClass            0 [unknown]
  bDeviceSubClass         0 [unknown]
  bDeviceProtocol         0 
  bMaxPacketSize0         9
  idVendor           0x174c ASMedia Technology Inc.
  idProduct          0x55aa ASM1051E SATA 6Gb/s bridge, ASM1053E SATA 6Gb/s bridge, ASM1153 SATA 3Gb/s bridge, ASM1153E SATA 6Gb/s bridge
  bcdDevice            1.00
  iManufacturer           2 Min Yi USB Device  
  iProduct                3 YZWY_TECH
  iSerial                 1 123456789020
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength       0x0079
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0xc0
      Self Powered
    MaxPower                0mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     80 Bulk-Only
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       1
      bNumEndpoints           4
      bInterfaceClass         8 Mass Storage
      bInterfaceSubClass      6 SCSI
      bInterfaceProtocol     98 USB Attached SCSI
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-in pipe (0x03)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Data-out pipe (0x04)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst              15
        MaxStreams             32
        Status pipe (0x02)
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x04  EP 4 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
        Command pipe (0x01)

 drivers/usb/storage/uas-detect.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
index 4d3b49e5b87a..f0d9748b0194 100644
--- a/drivers/usb/storage/uas-detect.h
+++ b/drivers/usb/storage/uas-detect.h
@@ -78,6 +78,8 @@ static int uas_use_uas_driver(struct usb_interface *intf,
 	 * ASM1051 - with broken (*) uas support
 	 * ASM1053 - with working uas support, but problems with large xfers
 	 * ASM1153 - with working uas support
+ * ASMT135x - broken uas support, shares the ASM1153 MaxPower == 0
+ *            signature, identify it by its product string
 	 *
 	 * Devices with these chips re-use a number of device-ids over the
 	 * entire line, so the device-id is useless to determine if we're
@@ -99,7 +101,10 @@ static int uas_use_uas_driver(struct usb_interface *intf,
 			(le16_to_cpu(udev->descriptor.idProduct) == 0x5106 ||
 			 le16_to_cpu(udev->descriptor.idProduct) == 0x55aa)) {
 		if (udev->actconfig->desc.bMaxPower == 0) {
-			/* ASM1153, do nothing */
+			if (udev->product && strstr(udev->product, "ASMT135"))
+				/* ASMT135x, broken uas */
+				flags |= US_FL_IGNORE_UAS;
+			/* else ASM1153, do nothing */
 		} else if (udev->speed < USB_SPEED_SUPER) {
 			/* No streams info, assume ASM1051 */
 			flags |= US_FL_IGNORE_UAS;
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-10-13 22:19 Olivier Kaloudoff
@ 2026-10-13 22:23 ` sashiko-bot
  2026-10-14  5:00 ` Greg KH
  2026-11-13 18:32 ` Eddie Chapman
  2 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-13 22:23 UTC (permalink / raw)
  To: Olivier Kaloudoff, linux-usb

> The ASMedia chip detection in uas_use_uas_driver() assumes that every
> device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
> config.MaxPower of 0 is an ASM1153 with working UAS.
> 
> ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa id and
> also report MaxPower == 0, so they take the "ASM1153, do nothing"
> path — but their UAS implementation is broken:
> 
> - The first READ(16) issued by sd probing times out after 30 s;
>   enumeration only completes after a uas_eh_abort_handler plus a full
>   uas_eh_host_reset_handler cycle:
> 
>     scsi 3:0:0:0: Direct-Access  ASMT  ASMT135x  0  PQ: 0 ANSI: 6
>     sd 3:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD IN
>     sd 3:0:0:0: [sdb] tag#26 CDB: Read(16) 88 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00
> [ ... ]
> with the equivalent usb-storage quirks parameter (174c:55aa:u) the
> device is completely stable.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Olivier Kaloudoff <olivier.kaloudoff@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013221944.41598-1-olivier.kaloudoff@gmail.com?part=1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-10-13 22:19 Olivier Kaloudoff
  2026-10-13 22:23 ` sashiko-bot
@ 2026-10-14  5:00 ` Greg KH
  2026-11-13 18:32 ` Eddie Chapman
  2 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2026-10-14  5:00 UTC (permalink / raw)
  To: Olivier Kaloudoff; +Cc: linux-usb, stern, usb-storage, stable

On Wed, Oct 14, 2026 at 12:19:44AM +0200, Olivier Kaloudoff wrote:
> diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
> index 4d3b49e5b87a..f0d9748b0194 100644
> --- a/drivers/usb/storage/uas-detect.h
> +++ b/drivers/usb/storage/uas-detect.h
> @@ -78,6 +78,8 @@ static int uas_use_uas_driver(struct usb_interface *intf,
>  	 * ASM1051 - with broken (*) uas support
>  	 * ASM1053 - with working uas support, but problems with large xfers
>  	 * ASM1153 - with working uas support
> + * ASMT135x - broken uas support, shares the ASM1153 MaxPower == 0
> + *            signature, identify it by its product string
>  	 *
>  	 * Devices with these chips re-use a number of device-ids over the
>  	 * entire line, so the device-id is useless to determine if we're

Please always check your patches before sending them out :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-10-13 22:19 Olivier Kaloudoff
  2026-10-13 22:23 ` sashiko-bot
  2026-10-14  5:00 ` Greg KH
@ 2026-11-13 18:32 ` Eddie Chapman
  2 siblings, 0 replies; 11+ messages in thread
From: Eddie Chapman @ 2026-11-13 18:32 UTC (permalink / raw)
  To: Olivier Kaloudoff, linux-usb; +Cc: stern, gregkh, usb-storage, stable

Hi Olivier,

On 13/10/2026 23:19, Olivier Kaloudoff wrote:
> The ASMedia chip detection in uas_use_uas_driver() assumes that every
> device with idVendor/idProduct 174c:5106 or 174c:55aa reporting a
> config.MaxPower of 0 is an ASM1153 with working UAS.
> 
> ASMT135x bridges (iProduct "ASMT135x") share the same 174c:55aa id and
> also report MaxPower == 0, so they take the "ASM1153, do nothing"
> path — but their UAS implementation is broken:

I've been following this thread with interest as I have a number of 
174c:55aa devices in use from different manufacturers.

May I trouble you to say the product/model of the Orico device you have 
which reports "ASMT135x" as the iProduct? Hopefully that's not too much 
of a pain to find on the casing or box if you still have it.

Also, is it still running whatever firmware it came with or has that 
been upgraded?

I'm asking purely for informational purposes. I just thought it would be 
really useful to have these two things documented in this thread if 
possible, for the benefit of anyone who might want to debug issues with 
this hardware in future.

As I'm sure you know, ascertaining the actual chip being used in these 
products is difficult without opening up the device to inspect the PCB. 
That's impractical in most cases but product model number can at least 
give a clue.

Many thanks!
Eddie




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
@ 2026-11-14 17:49 Olivier Kaloudoff
  2026-11-16 21:04 ` Eddie Chapman
  0 siblings, 1 reply; 11+ messages in thread
From: Olivier Kaloudoff @ 2026-11-14 17:49 UTC (permalink / raw)
  To: eddie; +Cc: linux-usb, stern, gregkh, oneukum, usb-storage, Olivier Kaloudoff

Hi Eddie,

On 13/11/2026 19:32, Eddie Chapman wrote:
> May I trouble you to say the product/model of the Orico device you have
> which reports "ASMT135x" as the iProduct?
>
> Also, is it still running whatever firmware it came with or has that
> been upgraded?

It's an ORICO C10 — sold as "ORICO C10 SSD Externe" (4 TB, "800 MB/s"
USB enclosure). Stock firmware; it has never been updated, there is no
vendor updater for it that I'm aware of.

Identification details for the record: idVendor/idProduct 174c:55aa,
iManufacturer "ASMT", iProduct "ASMT135x", bcdDevice 1.00.

Note the model is now discontinued — mine went back under a
defect-based refund (reallocated/pending sectors on the SSD itself),
which is how the UAS breakage was noticed in the first place.

Hope that helps,
Olivier

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-11-14 17:49 [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa) Olivier Kaloudoff
@ 2026-11-16 21:04 ` Eddie Chapman
  2026-11-17  8:34   ` Oliver Neukum
  0 siblings, 1 reply; 11+ messages in thread
From: Eddie Chapman @ 2026-11-16 21:04 UTC (permalink / raw)
  To: Olivier Kaloudoff; +Cc: linux-usb, stern, gregkh, oneukum, usb-storage

On 14/11/2026 17:49, Olivier Kaloudoff wrote:
> Hi Eddie,
> 
> On 13/11/2026 19:32, Eddie Chapman wrote:
>> May I trouble you to say the product/model of the Orico device you have
>> which reports "ASMT135x" as the iProduct?
>>
>> Also, is it still running whatever firmware it came with or has that
>> been upgraded?
> 
> It's an ORICO C10 — sold as "ORICO C10 SSD Externe" (4 TB, "800 MB/s"
> USB enclosure). Stock firmware; it has never been updated, there is no
> vendor updater for it that I'm aware of.
> 
> Identification details for the record: idVendor/idProduct 174c:55aa,
> iManufacturer "ASMT", iProduct "ASMT135x", bcdDevice 1.00.
> 
> Note the model is now discontinued — mine went back under a
> defect-based refund (reallocated/pending sectors on the SSD itself),
> which is how the UAS breakage was noticed in the first place.
> 
> Hope that helps,
> Olivier

Thanks Olivier. In my own experience just purchasing and using many 
Asmedia USB to SATA products over the years, they usually ship with 
quite old, buggy firmware, and the manufacturer rarely provides a 
firmware update. But there are various unofficial sources of newer 
firmware out there if you look. It goes without saying you have to 
decide for yourself if the obvious risk is worth taking. Generally these 
are either leaked, or are "extracted" from devices with newer firmware 
by users and shared. Sometimes one or two "good" manufacturers supply 
firmware updates for their products and the firmware enthusiast 
community subsequently finds that these apply fine to other equivalent 
product with the same chip.

There is an internal Asmedia firmware tool widely available online. If a 
manufacturer does provide a firmware update it will usually come 
packaged with that tool. It only runs on Windows (not sure about Mac, 
definitely not Linux). There are community efforts I've seen trying to 
develop alternative firmare tools.

Anyway, speaking purely from my own experience, I've always updated the 
firmware on my devices and there is no doubt in my mind that the newer 
firmware versions I've applied to my devices have resolved serious bugs 
in the older versions they were shipped with.

Bringing this a little bit back on topic for issues seen in the Linux 
kernel with Asmedia USB to SATA devices, I'd be willing to wager that a 
lot (if not most) of the time, if there is a firmware update out there 
for a chip, there's an excellent chance it will resolve the issue. But 
it is a mine field for users who are forced to take risks, and it is a 
very problematic situation for Linux to deal with to say the least.

Eddie

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-11-16 21:04 ` Eddie Chapman
@ 2026-11-17  8:34   ` Oliver Neukum
  2026-11-17 14:41     ` Eddie Chapman
  0 siblings, 1 reply; 11+ messages in thread
From: Oliver Neukum @ 2026-11-17  8:34 UTC (permalink / raw)
  To: Eddie Chapman, Olivier Kaloudoff
  Cc: linux-usb, stern, gregkh, oneukum, usb-storage



On 16.11.26 22:04, Eddie Chapman wrote:
> Bringing this a little bit back on topic for issues seen in the Linux kernel with Asmedia USB to SATA devices, I'd be willing to wager that a lot (if not most) of the time, if there is a firmware update out there for a chip, there's an excellent chance it will resolve the issue. But it is a mine field for users who are forced to take risks, and it is a very problematic situation for Linux to deal with to say the least.

Hi,

do they show a different version number?
If not, I am afraid we will have to be conservative
and blacklist everything.

	Regards
		Oliver


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-11-17  8:34   ` Oliver Neukum
@ 2026-11-17 14:41     ` Eddie Chapman
  2026-11-18  9:18       ` Oliver Neukum
  0 siblings, 1 reply; 11+ messages in thread
From: Eddie Chapman @ 2026-11-17 14:41 UTC (permalink / raw)
  To: Oliver Neukum, Olivier Kaloudoff; +Cc: linux-usb, stern, gregkh, usb-storage

On 17/11/2026 08:34, Oliver Neukum wrote:
> On 16.11.26 22:04, Eddie Chapman wrote:
>> Bringing this a little bit back on topic for issues seen in the Linux 
>> kernel with Asmedia USB to SATA devices, I'd be willing to wager that 
>> a lot (if not most) of the time, if there is a firmware update out 
>> there for a chip, there's an excellent chance it will resolve the 
>> issue. But it is a mine field for users who are forced to take risks, 
>> and it is a 
>> very problematic situation for Linux to deal with to say the least.
> 
> Hi,
> 
> do they show a different version number?
> If not, I am afraid we will have to be conservative
> and blacklist everything.
> 
>      Regards
>          Oliver

Hi Oliver,

Yes totally agreed, if the firmware version cannot be easily read from 
the device somehow, today, then the only and safest option for the 
kernel is to treat all such devices as if running older firmware. I 
mean, it is definitely *possible* to query the device to find its 
firmware version because Asmedia has firmware update utilities that do 
that under Windows. But I've no idea how. In an ideal world someone from 
Asmedia would one day provide a patch that exposes that info to the 
kernel somehow. In the absence of that perhaps one day someone will have 
the time to sniff USB packets using Qemu to see how it is done and 
submit a patch.

In the case of this particular device that reports "ASMT135x" as the 
iProduct seems it's a little unusual, I'd love to see what's printed on 
the chip on the PCB to confirm what it actually is, as you can easily 
write any string you like to iProduct in the Windows firmware utility. 
I've done that myself when updating firmware, here's one I did recently:

   idVendor           0x174c ASMedia Technology Inc.
   idProduct          0x235c DD25-C3-GY-BP
   bcdDevice            1.00
   iManufacturer           2 Orico
   iProduct                3 DD25-C3-GY-BP
   iSerial                 1 234567890126

That device from Orico that came with much older firmware initially 
reported a different idVendor and idProduct which I can't recall. But as 
part of the firmware update those 2 fields changed to the above and it 
is now recognised correctly by the kernel and works better, which is 
good. But the string "DD25-C3-GY-BP" *I* chose and set that in the 
firmware utility, it's just the model number of the device. But I could 
have set it to "111111" or anything else.

regards,
Eddie

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa)
  2026-11-17 14:41     ` Eddie Chapman
@ 2026-11-18  9:18       ` Oliver Neukum
  0 siblings, 0 replies; 11+ messages in thread
From: Oliver Neukum @ 2026-11-18  9:18 UTC (permalink / raw)
  To: Eddie Chapman, Olivier Kaloudoff; +Cc: linux-usb, stern, gregkh, usb-storage

On 17.11.26 15:41, Eddie Chapman wrote:
> Yes totally agreed, if the firmware version cannot be easily read from the device somehow, today, then the only and safest option for the kernel is to treat all such devices as if running older firmware. I mean, it is definitely *possible* to query the device to find its firmware version because Asmedia has firmware update utilities that do that under Windows. But I've no idea how. In an ideal world someone from Asmedia would one day provide a patch that exposes that info to the kernel somehow. In the absence of that perhaps one day someone will have the time to sniff USB packets using Qemu to see how it is done and submit a patch.

Hi,

do you know whether anyone has tried talking to Asmedia?

	Regards
		Oliver


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-11-18  9:18 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-14 17:49 [PATCH] usb: uas: ignore UAS for ASMT135x bridges (174c:55aa) Olivier Kaloudoff
2026-11-16 21:04 ` Eddie Chapman
2026-11-17  8:34   ` Oliver Neukum
2026-11-17 14:41     ` Eddie Chapman
2026-11-18  9:18       ` Oliver Neukum
  -- strict thread matches above, loose matches on Subject: below --
2026-10-13 22:19 Olivier Kaloudoff
2026-10-13 22:23 ` sashiko-bot
2026-10-14  5:00 ` Greg KH
2026-11-13 18:32 ` Eddie Chapman
2026-10-11 16:42 Olivier Kaloudoff
2026-10-11 16:47 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox