From: Esteban Urrutia <esteuwu@proton.me>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475
Date: Thu, 30 Jul 2026 16:38:52 +0000 [thread overview]
Message-ID: <4dcdfd25-edec-4ea9-8b80-2472e2b66e5e@proton.me> (raw)
In-Reply-To: <20260730-resourceful-scrupulous-goshawk-c9ea53@quoll>
On 7/30/26 5:03 AM, Krzysztof Kozlowski wrote:
> First, not true. You did not add compatible for pmic-glink.
>
> Second, that's redundant. You just repeated subject and the diff
> (although incorrectly). Explain why this is not compatible with existing
> variants, writing bindings EXPLICITLY ask for that.
Thanks for the heads up. Will fix it.
Regards,
Esteban
next prev parent reply other threads:[~2026-07-30 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 19:48 [PATCH 0/2] Support for pmic-glink in SM8475 Esteban Urrutia via B4 Relay
2026-07-29 19:48 ` [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475 Esteban Urrutia via B4 Relay
2026-07-30 9:03 ` Krzysztof Kozlowski
2026-07-30 16:38 ` Esteban Urrutia [this message]
2026-07-29 19:48 ` [PATCH 2/2] usb: typec: ucsi: ucsi_glink: " Esteban Urrutia via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dcdfd25-edec-4ea9-8b80-2472e2b66e5e@proton.me \
--to=esteuwu@proton.me \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox