From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>,
"balbi@kernel.org" <balbi@kernel.org>
Cc: "peter.chen@nxp.com" <peter.chen@nxp.com>,
"nsekhar@ti.com" <nsekhar@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rahul Kumar <kurahul@cadence.com>
Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
Date: Thu, 8 Oct 2020 13:18:42 +0300 [thread overview]
Message-ID: <527428cb-704b-a92f-ca7c-938527a91280@gmail.com> (raw)
In-Reply-To: <DM6PR07MB552984371C356A6E31D8D116DD0B0@DM6PR07MB5529.namprd07.prod.outlook.com>
Hello!
On 08.10.2020 6:57, Pawel Laszczak wrote:
> Siergei,
Sergei, or, more correctly, Sergey. :-)
>
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>> No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?
No, it's because the format is:
Fixes: <SHA1> ("<summary>")
no word "commit" is needed. :-)
>>> Acked-by: Roger Quadros <rogerq@ti.com>
>> [...]
>
> Regards,
> Pawel
MBR, Sergei
prev parent reply other threads:[~2020-10-08 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 3:39 [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used Pawel Laszczak
2020-10-07 8:15 ` Roger Quadros
2020-10-07 10:28 ` Sergei Shtylyov
2020-10-08 3:57 ` Pawel Laszczak
2020-10-08 7:29 ` Roger Quadros
2020-10-08 10:18 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527428cb-704b-a92f-ca7c-938527a91280@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox