From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <balbi@kernel.org>
Cc: <peter.chen@nxp.com>, <nsekhar@ti.com>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kurahul@cadence.com>
Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used
Date: Wed, 7 Oct 2020 11:15:01 +0300 [thread overview]
Message-ID: <8994106d-2cc5-fa2c-bbcc-6526632ff80b@ti.com> (raw)
In-Reply-To: <20201007033932.23050-1-pawell@cadence.com>
On 07/10/2020 06:39, Pawel Laszczak wrote:
> Patch removes not used variable 'length' from
> cdns3_wa2_descmiss_copy_data function.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 6e7b70a2e352..692acf7b9b14 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> int chunk_end;
> - int length;
>
> descmiss_priv_req =
> cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
> @@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> break;
>
> chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
> - length = request->actual + descmiss_req->actual;
> request->status = descmiss_req->status;
> __cdns3_descmiss_copy_data(request, descmiss_req);
> list_del_init(&descmiss_priv_req->list);
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-10-07 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 3:39 [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used Pawel Laszczak
2020-10-07 8:15 ` Roger Quadros [this message]
2020-10-07 10:28 ` Sergei Shtylyov
2020-10-08 3:57 ` Pawel Laszczak
2020-10-08 7:29 ` Roger Quadros
2020-10-08 10:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8994106d-2cc5-fa2c-bbcc-6526632ff80b@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox