From: Andrew Lunn <andrew@lunn.ch>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Mark Einon" <mark.einon@gmail.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Iyappan Subramanian" <iyappan@os.amperecomputing.com>,
"Keyur Chudgar" <keyur@os.amperecomputing.com>,
"Quan Nguyen" <quan@os.amperecomputing.com>,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Doug Berger" <opendmb@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Jian Shen" <shenjian15@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Parthiban Veerasooran" <parthiban.veerasooran@microchip.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Jiawen Wu" <jiawenwu@trustnetic.com>,
"Mengyuan Lou" <mengyuanlou@net-swift.com>,
"Imre Kaloz" <kaloz@openwrt.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com, "Simon Horman" <horms@kernel.org>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>
Subject: Re: [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach
Date: Sat, 21 Jun 2025 10:01:47 +0200 [thread overview]
Message-ID: <5c32afad-5e25-4a35-8bdd-b78949c117ce@lunn.ch> (raw)
In-Reply-To: <20250620143341.2158655-1-kory.maincent@bootlin.com>
> +/**
> + * phy_disconnect_rtnl - disable interrupts, stop state machine, and detach a PHY
> + * device
> + * @phydev: target phy_device struct
> + *
> + * This is a wrapper around phy_disconnect that takes the rtnl semaphore.
> + */
Developers are likely to get this wrong, because generally they don't
need to bother with RTNL, the core does it. Could you add some
guidance here when this should be used, and when not.
Andrew
prev parent reply other threads:[~2025-06-21 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 14:33 [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach Kory Maincent
2025-06-20 14:56 ` Russell King (Oracle)
2025-06-20 16:25 ` Florian Fainelli
2025-06-21 7:48 ` Andrew Lunn
2025-06-21 8:01 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c32afad-5e25-4a35-8bdd-b78949c117ce@lunn.ch \
--to=andrew@lunn.ch \
--cc=Shyam-sundar.S-k@amd.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=afaerber@suse.de \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=iyappan@os.amperecomputing.com \
--cc=jiawenwu@trustnetic.com \
--cc=kaloz@openwrt.org \
--cc=keyur@os.amperecomputing.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mani@kernel.org \
--cc=mark.einon@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mengyuanlou@net-swift.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=olteanv@gmail.com \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=pavan.chebbi@broadcom.com \
--cc=quan@os.amperecomputing.com \
--cc=rafal@milecki.pl \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sgoutham@marvell.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=steve.glendinning@shawell.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=ulli.kroll@googlemail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox