[PATCH] HID: pidff: fix OOB write when hid->inputs is empty

[PATCH] HID: pidff: fix OOB write when hid->inputs is empty

[Baul Lee]

hid_pidff_init_with_quirks() derives its input_dev from

	list_entry(hid->inputs.next, struct hid_input, list)

without first checking that hid->inputs is non-empty.  The list member
of struct hid_input is at offset 0, so on an empty list list_entry()
yields &hid->inputs itself and the following hidinput->input load reads
an unrelated member of struct hid_device.  dev is then a type-confused
pointer, and force-feedback init writes through it: each
set_bit(FF_*, dev->ffbit) stores 8 bytes at dev + 192, past the end of
the object dev actually aliases, and input_ff_create() adds further
writes of a heap pointer and two function pointers.

Until hid-universal-pidff the only caller was hid_pidff_init() from
usbhid, which runs under HID_CLAIMED_INPUT and therefore always has at
least one hid_input.  universal_pidff_probe() starts the device with
HID_CONNECT_DEFAULT & ~HID_CONNECT_FF and then calls
hid_pidff_init_with_quirks() directly whenever the descriptor carries a
PID usage page, bypassing that gate.  A report descriptor whose only
application collection is on HID_UP_PID leaves hid->inputs empty while
hid_connect() still succeeds through the hidraw claim, so probe reaches
the unguarded list_entry().

The write happens in the USB probe path, on the hotplug workqueue, so
plugging in a malicious device is enough to trigger it; no attacker
software and no logged-in user are required.  KASAN reports an 8-byte
out-of-bounds write in hid_pidff_init_with_quirks() reached from
universal_pidff_probe().

Check for an empty list before deriving dev and return -ENODEV, as the
other HID force-feedback drivers already do.  universal_pidff_probe()
propagates the error and unwinds.

Discovered by XBOW, triaged by Baul Lee <baul.lee@xbow.com>

Fixes: f06bf8d94fff ("HID: Add hid-universal-pidff driver and supported device ids")
Reported-by: Federico Kirschbaum <federico.kirschbaum@xbow.com>
Reported-by: Baul Lee <baul.lee@xbow.com>
Cc: stable@vger.kernel.org
Signed-off-by: Baul Lee <baul.lee@xbow.com>
---
 drivers/hid/usbhid/hid-pidff.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index 5f4395f7c645..22951b7ecd17 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -1539,13 +1539,20 @@ static int pidff_check_autocenter(struct pidff_device *pidff,
 int hid_pidff_init_with_quirks(struct hid_device *hid, u32 initial_quirks)
 {
 	struct pidff_device *pidff;
-	struct hid_input *hidinput =
-		list_entry(hid->inputs.next, struct hid_input, list);
-	struct input_dev *dev = hidinput->input;
+	struct hid_input *hidinput;
+	struct input_dev *dev;
 	struct ff_device *ff;
 	int max_effects;
 	int error;
 
+	if (list_empty(&hid->inputs)) {
+		hid_err(hid, "no inputs found\n");
+		return -ENODEV;
+	}
+
+	hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+	dev = hidinput->input;
+
 	hid_dbg(hid, "starting pid init\n");
 
 	if (list_empty(&hid->report_enum[HID_OUTPUT_REPORT].report_list)) {
-- 
2.50.1 (Apple Git-155)

Re: [PATCH] HID: pidff: fix OOB write when hid->inputs is empty

[Tomasz Pakuła]

On Sun, 2026-07-26 at 15:25 +0900, Baul Lee wrote:
> hid_pidff_init_with_quirks() derives its input_dev from
> 
> 	list_entry(hid->inputs.next, struct hid_input, list)
> 
> without first checking that hid->inputs is non-empty.  The list member
> of struct hid_input is at offset 0, so on an empty list list_entry()
> yields &hid->inputs itself and the following hidinput->input load reads
> an unrelated member of struct hid_device.  dev is then a type-confused
> pointer, and force-feedback init writes through it: each
> set_bit(FF_*, dev->ffbit) stores 8 bytes at dev + 192, past the end of
> the object dev actually aliases, and input_ff_create() adds further
> writes of a heap pointer and two function pointers.
> 
> Until hid-universal-pidff the only caller was hid_pidff_init() from
> usbhid, which runs under HID_CLAIMED_INPUT and therefore always has at
> least one hid_input.  universal_pidff_probe() starts the device with
> HID_CONNECT_DEFAULT & ~HID_CONNECT_FF and then calls
> hid_pidff_init_with_quirks() directly whenever the descriptor carries a
> PID usage page, bypassing that gate.  A report descriptor whose only
> application collection is on HID_UP_PID leaves hid->inputs empty while
> hid_connect() still succeeds through the hidraw claim, so probe reaches
> the unguarded list_entry().
> 
> The write happens in the USB probe path, on the hotplug workqueue, so
> plugging in a malicious device is enough to trigger it; no attacker
> software and no logged-in user are required.  KASAN reports an 8-byte
> out-of-bounds write in hid_pidff_init_with_quirks() reached from
> universal_pidff_probe().
> 
> Check for an empty list before deriving dev and return -ENODEV, as the
> other HID force-feedback drivers already do.  universal_pidff_probe()
> propagates the error and unwinds.
> 
> Discovered by XBOW, triaged by Baul Lee <baul.lee@xbow.com>
> 
> Fixes: f06bf8d94fff ("HID: Add hid-universal-pidff driver and supported device ids")
> Reported-by: Federico Kirschbaum <federico.kirschbaum@xbow.com>
> Reported-by: Baul Lee <baul.lee@xbow.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Baul Lee <baul.lee@xbow.com>
> ---
>  drivers/hid/usbhid/hid-pidff.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
> index 5f4395f7c645..22951b7ecd17 100644
> --- a/drivers/hid/usbhid/hid-pidff.c
> +++ b/drivers/hid/usbhid/hid-pidff.c
> @@ -1539,13 +1539,20 @@ static int pidff_check_autocenter(struct pidff_device *pidff,
>  int hid_pidff_init_with_quirks(struct hid_device *hid, u32 initial_quirks)
>  {
>  	struct pidff_device *pidff;
> -	struct hid_input *hidinput =
> -		list_entry(hid->inputs.next, struct hid_input, list);
> -	struct input_dev *dev = hidinput->input;
> +	struct hid_input *hidinput;
> +	struct input_dev *dev;
>  	struct ff_device *ff;
>  	int max_effects;
>  	int error;
>  
> +	if (list_empty(&hid->inputs)) {
> +		hid_err(hid, "no inputs found\n");
> +		return -ENODEV;
> +	}
> +
> +	hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
> +	dev = hidinput->input;
> +
>  	hid_dbg(hid, "starting pid init\n");
>  
>  	if (list_empty(&hid->report_enum[HID_OUTPUT_REPORT].report_list)) {

Looks good, doesn't break anything and will help in such scenario.
Thanks!
-- 
Reviewed-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>