Linux USB
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
	johan@kernel.org, gregkh@linuxfoundation.org
Cc: hyamamo@allied-telesis.co.jp, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F
Date: Wed, 14 Sep 2022 11:10:12 +0700	[thread overview]
Message-ID: <621867a7-e513-c0c8-fb4f-2116d3aa8c7c@gmail.com> (raw)
In-Reply-To: <20220914025541.1018233-3-chris.packham@alliedtelesis.co.nz>

On 9/14/2022 09:55, Chris Packham wrote:
> Add support for the docomo L-03F modem.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>   drivers/usb/serial/option.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2065f0fb2fa0..14eaff50820b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb);
>   /* LG products */
>   #define LG_VENDOR_ID				0x1004
>   #define LG_PRODUCT_L02C				0x618f
> +#define LG_PRODUCT_L03F				0x6366
>   
>   /* MediaTek products */
>   #define MEDIATEK_VENDOR_ID			0x0e8d
> @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) },
>   	{ USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C modem */
> +	{ USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F modem */
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) },


Hi,
this doesn't seem to be correct. Since this is a LTE CAT3 highspeed 
device and the modem manual mentions MS Win NDIS driver then one 
interface is likely to be a QMI interface which you must blacklist in 
the option driver.
Please provide a usb-devices or verbose lsusb output for the modem.

thanks
Lars

  reply	other threads:[~2022-09-14  4:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  2:55 [PATCH 0/2] USB: serial: option: add NetIndex UX302NC and docomo L-03F Chris Packham
2022-09-14  2:55 ` [PATCH 1/2] USB: serial: option: add support for NetIndex UX302NC Chris Packham
2022-09-14  2:55 ` [PATCH 2/2] USB: serial: option: add support for docomo L-03F Chris Packham
2022-09-14  4:10   ` Lars Melin [this message]
2022-09-14  4:18     ` Chris Packham
2022-10-06 19:44       ` Chris Packham
2022-10-07  0:02         ` Lars Melin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=621867a7-e513-c0c8-fb4f-2116d3aa8c7c@gmail.com \
    --to=larsm17@gmail.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=gregkh@linuxfoundation.org \
    --cc=hyamamo@allied-telesis.co.jp \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox