* [PATCH 0/2] USB: serial: option: add NetIndex UX302NC and docomo L-03F @ 2022-09-14 2:55 Chris Packham 2022-09-14 2:55 ` [PATCH 1/2] USB: serial: option: add support for NetIndex UX302NC Chris Packham 2022-09-14 2:55 ` [PATCH 2/2] USB: serial: option: add support for docomo L-03F Chris Packham 0 siblings, 2 replies; 7+ messages in thread From: Chris Packham @ 2022-09-14 2:55 UTC (permalink / raw) To: johan, gregkh; +Cc: hyamamo, linux-usb, linux-kernel, Chris Packham This is a couple of patches we've been carrying around in our tree for a while. I'm not sure why they weren't submitted upstreamed (probably because I didn't nag loud enough at the time) so I'm doing it now. Chris Packham (2): USB: serial: option: add support for NetIndex UX302NC USB: serial: option: add support for docomo L-03F drivers/usb/serial/option.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.37.3 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] USB: serial: option: add support for NetIndex UX302NC 2022-09-14 2:55 [PATCH 0/2] USB: serial: option: add NetIndex UX302NC and docomo L-03F Chris Packham @ 2022-09-14 2:55 ` Chris Packham 2022-09-14 2:55 ` [PATCH 2/2] USB: serial: option: add support for docomo L-03F Chris Packham 1 sibling, 0 replies; 7+ messages in thread From: Chris Packham @ 2022-09-14 2:55 UTC (permalink / raw) To: johan, gregkh; +Cc: hyamamo, linux-usb, linux-kernel, Chris Packham Add support for the following USB Modem usb 1-1: new high-speed USB device number 3 using xhci-hcd usb 1-1: New USB device found, idVendor=11f6, idProduct=1034 usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 1-1: Product: NCXX UX302NC usb 1-1: Manufacturer: NCXX Inc. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- drivers/usb/serial/option.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a5e8374a8d71..2065f0fb2fa0 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -580,6 +580,9 @@ static void option_instat_callback(struct urb *urb); #define OPPO_VENDOR_ID 0x22d9 #define OPPO_PRODUCT_R11 0x276c +/* NetIndex */ +#define NETINDEX_VENDOR_ID 0x11f6 +#define NETINDEX_PRODUCT_UX302NC 0x1034 /* Device flags */ @@ -2170,6 +2173,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1405, 0xff) }, /* GosunCn GM500 MBIM */ { USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1406, 0xff) }, /* GosunCn GM500 ECM/NCM */ { USB_DEVICE_AND_INTERFACE_INFO(OPPO_VENDOR_ID, OPPO_PRODUCT_R11, 0xff, 0xff, 0x30) }, + { USB_DEVICE(NETINDEX_VENDOR_ID, NETINDEX_PRODUCT_UX302NC) }, /* NCXX UX302NC */ { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids); -- 2.37.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] USB: serial: option: add support for docomo L-03F 2022-09-14 2:55 [PATCH 0/2] USB: serial: option: add NetIndex UX302NC and docomo L-03F Chris Packham 2022-09-14 2:55 ` [PATCH 1/2] USB: serial: option: add support for NetIndex UX302NC Chris Packham @ 2022-09-14 2:55 ` Chris Packham 2022-09-14 4:10 ` Lars Melin 1 sibling, 1 reply; 7+ messages in thread From: Chris Packham @ 2022-09-14 2:55 UTC (permalink / raw) To: johan, gregkh; +Cc: hyamamo, linux-usb, linux-kernel, Chris Packham Add support for the docomo L-03F modem. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 2065f0fb2fa0..14eaff50820b 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb); /* LG products */ #define LG_VENDOR_ID 0x1004 #define LG_PRODUCT_L02C 0x618f +#define LG_PRODUCT_L03F 0x6366 /* MediaTek products */ #define MEDIATEK_VENDOR_ID 0x0e8d @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) }, { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C modem */ + { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F modem */ { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) }, -- 2.37.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F 2022-09-14 2:55 ` [PATCH 2/2] USB: serial: option: add support for docomo L-03F Chris Packham @ 2022-09-14 4:10 ` Lars Melin 2022-09-14 4:18 ` Chris Packham 0 siblings, 1 reply; 7+ messages in thread From: Lars Melin @ 2022-09-14 4:10 UTC (permalink / raw) To: Chris Packham, johan, gregkh; +Cc: hyamamo, linux-usb, linux-kernel On 9/14/2022 09:55, Chris Packham wrote: > Add support for the docomo L-03F modem. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 2065f0fb2fa0..14eaff50820b 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb); > /* LG products */ > #define LG_VENDOR_ID 0x1004 > #define LG_PRODUCT_L02C 0x618f > +#define LG_PRODUCT_L03F 0x6366 > > /* MediaTek products */ > #define MEDIATEK_VENDOR_ID 0x0e8d > @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) }, > { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C modem */ > + { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F modem */ > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) }, > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) }, > { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) }, Hi, this doesn't seem to be correct. Since this is a LTE CAT3 highspeed device and the modem manual mentions MS Win NDIS driver then one interface is likely to be a QMI interface which you must blacklist in the option driver. Please provide a usb-devices or verbose lsusb output for the modem. thanks Lars ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F 2022-09-14 4:10 ` Lars Melin @ 2022-09-14 4:18 ` Chris Packham 2022-10-06 19:44 ` Chris Packham 0 siblings, 1 reply; 7+ messages in thread From: Chris Packham @ 2022-09-14 4:18 UTC (permalink / raw) To: Lars Melin, johan@kernel.org, gregkh@linuxfoundation.org Cc: Hiroyuki Yamamoto, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org On 14/09/22 16:10, Lars Melin wrote: > On 9/14/2022 09:55, Chris Packham wrote: >> Add support for the docomo L-03F modem. >> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> >> --- >> drivers/usb/serial/option.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >> index 2065f0fb2fa0..14eaff50820b 100644 >> --- a/drivers/usb/serial/option.c >> +++ b/drivers/usb/serial/option.c >> @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb); >> /* LG products */ >> #define LG_VENDOR_ID 0x1004 >> #define LG_PRODUCT_L02C 0x618f >> +#define LG_PRODUCT_L03F 0x6366 >> /* MediaTek products */ >> #define MEDIATEK_VENDOR_ID 0x0e8d >> @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = { >> { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, >> VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) }, >> { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, >> 0xff, 0xff, 0xff) }, >> { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C >> modem */ >> + { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F >> modem */ >> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, >> 0xff, 0x00, 0x00) }, >> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, >> 0xff, 0x02, 0x01) }, >> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, >> 0xff, 0x00, 0x00) }, > > > Hi, > this doesn't seem to be correct. Since this is a LTE CAT3 highspeed > device and the modem manual mentions MS Win NDIS driver then one > interface is likely to be a QMI interface which you must blacklist in > the option driver. > Please provide a usb-devices or verbose lsusb output for the modem. Yamamoto-san, are you able to provide the lsusb -v output for this device? (Our internal issue for the code change is CR-56120). > > thanks > Lars ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F 2022-09-14 4:18 ` Chris Packham @ 2022-10-06 19:44 ` Chris Packham 2022-10-07 0:02 ` Lars Melin 0 siblings, 1 reply; 7+ messages in thread From: Chris Packham @ 2022-10-06 19:44 UTC (permalink / raw) To: Lars Melin, johan@kernel.org, gregkh@linuxfoundation.org Cc: Hiroyuki Yamamoto, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Hi Lars, On 14/09/22 16:18, Chris Packham wrote: > > On 14/09/22 16:10, Lars Melin wrote: >> On 9/14/2022 09:55, Chris Packham wrote: >>> Add support for the docomo L-03F modem. >>> >>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> >>> --- >>> drivers/usb/serial/option.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >>> index 2065f0fb2fa0..14eaff50820b 100644 >>> --- a/drivers/usb/serial/option.c >>> +++ b/drivers/usb/serial/option.c >>> @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb >>> *urb); >>> /* LG products */ >>> #define LG_VENDOR_ID 0x1004 >>> #define LG_PRODUCT_L02C 0x618f >>> +#define LG_PRODUCT_L03F 0x6366 >>> /* MediaTek products */ >>> #define MEDIATEK_VENDOR_ID 0x0e8d >>> @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] >>> = { >>> { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, >>> VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) }, >>> { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, >>> 0xff, 0xff, 0xff) }, >>> { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C >>> modem */ >>> + { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F >>> modem */ >>> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, >>> 0xff, 0x00, 0x00) }, >>> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, >>> 0xff, 0x02, 0x01) }, >>> { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, >>> 0xff, 0x00, 0x00) }, >> >> >> Hi, >> this doesn't seem to be correct. Since this is a LTE CAT3 highspeed >> device and the modem manual mentions MS Win NDIS driver then one >> interface is likely to be a QMI interface which you must blacklist in >> the option driver. >> Please provide a usb-devices or verbose lsusb output for the modem. > > Yamamoto-san, are you able to provide the lsusb -v output for this > device? (Our internal issue for the code change is CR-56120). > Just following up on this. I've not been able to track down one of the actual modems and have had radio silence from my colleagues who did the original work. Is the 1/2 patch of this series acceptable on it's own? (should I rebase and resubmit it). >> >> thanks >> Lars ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F 2022-10-06 19:44 ` Chris Packham @ 2022-10-07 0:02 ` Lars Melin 0 siblings, 0 replies; 7+ messages in thread From: Lars Melin @ 2022-10-07 0:02 UTC (permalink / raw) To: Chris Packham, johan@kernel.org, gregkh@linuxfoundation.org Cc: Hiroyuki Yamamoto, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org On 10/7/2022 02:44, Chris Packham wrote: > Hi Lars, > Just following up on this. I've not been able to track down one of the > actual modems and have had radio silence from my colleagues who did the > original work. > > Is the 1/2 patch of this series acceptable on it's own? (should I rebase > and resubmit it). > Patch 1/2 for NetIndex UX302NC USB modem has the same error as patch 2/2 for the Docomo USB modem, both are LTE CAT3 devices and there is no mfgr providing only a serial ppp dial-up modem interface for high-speed devices like these, they always have a direct net interface. I have dug up the driver installer from NetIndex web site, the interface usage is: MI_00 NCXX UX302NC HS-USB Diagnostics MI_01 NCXX UX302NC HS-USB Modem MI_02 NCXX UX302NC HS-USB Application MI_03 NCXX UX302NC Ethernet Adapter and info in the driver files tells us that the chip mfgr is Qualcomm and the net interface is QMI so it must be blacklisted in the option driver. thanks Lars ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-07 0:02 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-14 2:55 [PATCH 0/2] USB: serial: option: add NetIndex UX302NC and docomo L-03F Chris Packham 2022-09-14 2:55 ` [PATCH 1/2] USB: serial: option: add support for NetIndex UX302NC Chris Packham 2022-09-14 2:55 ` [PATCH 2/2] USB: serial: option: add support for docomo L-03F Chris Packham 2022-09-14 4:10 ` Lars Melin 2022-09-14 4:18 ` Chris Packham 2022-10-06 19:44 ` Chris Packham 2022-10-07 0:02 ` Lars Melin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox