From: Oliver Neukum <oneukum@suse.com>
To: Jeongjun Park <aha310510@gmail.com>, oneukum@suse.com
Cc: colin.i.king@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: use mutex_lock in iowarrior_read()
Date: Tue, 17 Sep 2024 18:02:42 +0200 [thread overview]
Message-ID: <64dfb120-3a95-44dd-a50c-c4818baeb833@suse.com> (raw)
In-Reply-To: <20240917154107.137653-1-aha310510@gmail.com>
On 17.09.24 17:41, Jeongjun Park wrote:
Hi,
comments in line.
> ---
> drivers/usb/misc/iowarrior.c | 46 ++++++++++++++++++++++++++++--------
> 1 file changed, 36 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
> index 6d28467ce352..dbf0ed04f7c3 100644
> --- a/drivers/usb/misc/iowarrior.c
> +++ b/drivers/usb/misc/iowarrior.c
> @@ -277,28 +277,45 @@ static ssize_t iowarrior_read(struct file *file, char __user *buffer,
> struct iowarrior *dev;
> int read_idx;
> int offset;
> + int retval = 0;
Initialization is useless.
The rest is fine.
Regards
Oliver
next prev parent reply other threads:[~2024-09-17 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 4:06 [PATCH] usb: use mutex_lock in iowarrior_read() Jeongjun Park
2024-09-16 4:15 ` Greg KH
2024-09-16 4:43 ` Jeongjun Park
2024-09-16 6:50 ` Greg KH
2024-09-16 8:35 ` Oliver Neukum
2024-09-16 12:44 ` Jeongjun Park
2024-09-16 13:15 ` Oliver Neukum
2024-09-17 6:23 ` Jeongjun Park
2024-09-17 8:33 ` Oliver Neukum
2024-09-17 10:01 ` Jeongjun Park
2024-09-17 13:17 ` Oliver Neukum
2024-09-17 15:41 ` Jeongjun Park
2024-09-17 16:02 ` Oliver Neukum [this message]
2024-09-17 16:09 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64dfb120-3a95-44dd-a50c-c4818baeb833@suse.com \
--to=oneukum@suse.com \
--cc=aha310510@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox