From: Oliver Neukum <oneukum@suse.com>
To: Jeongjun Park <aha310510@gmail.com>, Oliver Neukum <oneukum@suse.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
colin.i.king@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: use mutex_lock in iowarrior_read()
Date: Tue, 17 Sep 2024 15:17:23 +0200 [thread overview]
Message-ID: <d88289f9-e22a-4960-9b3b-ad0b3ab17a89@suse.com> (raw)
In-Reply-To: <CAO9qdTH_+syAOBXUYT61VZMovDJYjCD1b-Who16Aqj4BXq8GLA@mail.gmail.com>
On 17.09.24 12:01, Jeongjun Park wrote:
> Okay, I understand. Then I think it would be appropriate to do
> the patch below to prevent blocking, but I have one question.
>
> Currently, many misc usb drivers do not seem to handle the
> O_NONBLOCK flag when using mutex_lock. If this is really
Yes. The quality of many drivers could be improved.
Feel free to make patches. However, the lack of quality elsewhere
does not justify a regression. Hence code fixing drivers already
correctly supporting O_NONBLOCK must be correct in that regard.
> necessary code, I think it would require code modifications to
> other functions inside iowarrior and many misc usb drivers.
>
> What do you think about this?
The formatting seems to be broken. In terms of content it is good.
Regards
Oliver
next prev parent reply other threads:[~2024-09-17 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 4:06 [PATCH] usb: use mutex_lock in iowarrior_read() Jeongjun Park
2024-09-16 4:15 ` Greg KH
2024-09-16 4:43 ` Jeongjun Park
2024-09-16 6:50 ` Greg KH
2024-09-16 8:35 ` Oliver Neukum
2024-09-16 12:44 ` Jeongjun Park
2024-09-16 13:15 ` Oliver Neukum
2024-09-17 6:23 ` Jeongjun Park
2024-09-17 8:33 ` Oliver Neukum
2024-09-17 10:01 ` Jeongjun Park
2024-09-17 13:17 ` Oliver Neukum [this message]
2024-09-17 15:41 ` Jeongjun Park
2024-09-17 16:02 ` Oliver Neukum
2024-09-17 16:09 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d88289f9-e22a-4960-9b3b-ad0b3ab17a89@suse.com \
--to=oneukum@suse.com \
--cc=aha310510@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox