Linux USB
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Foster Snowhill <forst@pen.gy>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Georgi Valkov <gvalkov@gmail.com>,
	Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next] usbnet: ipheth: prevent OoB reads of NDP16
Date: Mon, 9 Sep 2024 10:47:11 +0200	[thread overview]
Message-ID: <8510a98e-f950-4349-99bc-9d36febe94d3@suse.com> (raw)
In-Reply-To: <20240907230108.978355-1-forst@pen.gy>

Hi,

On 08.09.24 01:01, Foster Snowhill wrote:

> To address the above issues without reimplementing more of CDC NCM,
> rely on and check for a specific fixed format of incoming URBs
> expected from an iOS device:
> 
> * 12-byte NTH16
> * 96-byte NDP16, allowing up to 22 DPEs (up to 21 datagrams + trailer)

I am afraid this is an approach we must not take. We cannot rely on
a specific device's behavior in a class driver.

This is a NACK.

	Regards
		Oliver

  reply	other threads:[~2024-09-09  8:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07 23:01 [PATCH net-next] usbnet: ipheth: prevent OoB reads of NDP16 Foster Snowhill
2024-09-09  8:47 ` Oliver Neukum [this message]
2024-09-09  9:04   ` Foster Snowhill
2024-09-09 11:04     ` Oliver Neukum
2024-09-09 13:39       ` Foster Snowhill
2024-09-09 14:12         ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8510a98e-f950-4349-99bc-9d36febe94d3@suse.com \
    --to=oneukum@suse.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=forst@pen.gy \
    --cc=gvalkov@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox