From: Oliver Neukum <oneukum@suse.com>
To: Foster Snowhill <forst@pen.gy>, Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Georgi Valkov <gvalkov@gmail.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next] usbnet: ipheth: prevent OoB reads of NDP16
Date: Mon, 9 Sep 2024 13:04:43 +0200 [thread overview]
Message-ID: <d15bc43b-f130-4fd1-a758-b19b2dc99d46@suse.com> (raw)
In-Reply-To: <4be673c9-b06a-4c2d-8b27-a1e91150df94@pen.gy>
On 09.09.24 11:04, Foster Snowhill wrote:
> Thus the `ipheth` driver does not aim to be a CDC NCM-compliant
> implementation and, in fact, can't be one because of the points above.
>
> For a complete spec-compliant CDC NCM implementation, there is already
> the `cdc_ncm` driver. This driver is used for reverse tethering (sharing
> computer's internet connection with an attached phone) on iPhones. This
> patch does not in any way change `cdc_ncm`.
>
> With all of the above, does your NACK still stand? Thanks!
Hi,
I am sorry for the confusion. May I suggest a reformulation of the
commit message. It reads like this patch is intended for generic CDC-NCM.
I withdraw my objections. They were based on a confusion.
Regards
Oliver
next prev parent reply other threads:[~2024-09-09 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 23:01 [PATCH net-next] usbnet: ipheth: prevent OoB reads of NDP16 Foster Snowhill
2024-09-09 8:47 ` Oliver Neukum
2024-09-09 9:04 ` Foster Snowhill
2024-09-09 11:04 ` Oliver Neukum [this message]
2024-09-09 13:39 ` Foster Snowhill
2024-09-09 14:12 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d15bc43b-f130-4fd1-a758-b19b2dc99d46@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=forst@pen.gy \
--cc=gvalkov@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox