* [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe
@ 2020-12-15 2:54 Zheng Zengkai
2020-12-23 2:13 ` Zheng Zengkai
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Zengkai @ 2020-12-15 2:54 UTC (permalink / raw)
To: balbi, gregkh, khilman, narmstrong, jbrunet, martin.blumenstingl
Cc: linux-usb, linux-arm-kernel, linux-amlogic, linux-kernel,
zhengzengkai
dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
on one error handling path. This patch fixes that.
Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index 417e05381b5d..bdf1f98dfad8 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
ret = priv->drvdata->setup_regmaps(priv, base);
if (ret)
- return ret;
+ goto err_disable_clks;
if (priv->vbus) {
ret = regulator_enable(priv->vbus);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-12-15 2:54 [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe Zheng Zengkai
@ 2020-12-23 2:13 ` Zheng Zengkai
2020-12-23 8:11 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Zengkai @ 2020-12-23 2:13 UTC (permalink / raw)
To: balbi, gregkh, khilman, narmstrong, jbrunet, martin.blumenstingl
Cc: linux-usb, linux-arm-kernel, linux-amlogic, linux-kernel
Hi everyone,
Friendly ping:
Just want to know why this patch was ignored,
Am I missing something?
Merry Christmas and Happy New Year!
> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
> on one error handling path. This patch fixes that.
>
> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index 417e05381b5d..bdf1f98dfad8 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
>
> ret = priv->drvdata->setup_regmaps(priv, base);
> if (ret)
> - return ret;
> + goto err_disable_clks;
>
> if (priv->vbus) {
> ret = regulator_enable(priv->vbus);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-12-23 2:13 ` Zheng Zengkai
@ 2020-12-23 8:11 ` Greg KH
2020-12-23 14:41 ` Zheng Zengkai
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-12-23 8:11 UTC (permalink / raw)
To: Zheng Zengkai
Cc: balbi, khilman, narmstrong, jbrunet, martin.blumenstingl,
linux-usb, linux-arm-kernel, linux-amlogic, linux-kernel
On Wed, Dec 23, 2020 at 10:13:03AM +0800, Zheng Zengkai wrote:
> Hi everyone,
>
> Friendly ping:
>
> Just want to know why this patch was ignored,
Right now it is the merge window and we can't do anything with any
patches until 5.11-rc1 is out. After that happens, I'll work on
catching up on older patches like this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-12-23 8:11 ` Greg KH
@ 2020-12-23 14:41 ` Zheng Zengkai
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Zengkai @ 2020-12-23 14:41 UTC (permalink / raw)
To: Greg KH
Cc: balbi, khilman, narmstrong, jbrunet, martin.blumenstingl,
linux-usb, linux-arm-kernel, linux-amlogic, linux-kernel
Hi Greg,
> On Wed, Dec 23, 2020 at 10:13:03AM +0800, Zheng Zengkai wrote:
>> Hi everyone,
>>
>> Friendly ping:
>>
>> Just want to know why this patch was ignored,
> Right now it is the merge window and we can't do anything with any
> patches until 5.11-rc1 is out. After that happens, I'll work on
> catching up on older patches like this.
>
> thanks,
>
> greg k-h
> .
Thank you very much for your reply and information!
Best Regards,
Zheng Zengkai
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-23 14:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 2:54 [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe Zheng Zengkai
2020-12-23 2:13 ` Zheng Zengkai
2020-12-23 8:11 ` Greg KH
2020-12-23 14:41 ` Zheng Zengkai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox