Linux USB
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Jack Pham <quic_jackp@quicinc.com>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Pratham Pratap <quic_ppratap@quicinc.com>
Subject: Re: [PATCH v2] usb: roles: disable pm for role switch device
Date: Mon, 6 Feb 2023 13:31:41 +0200	[thread overview]
Message-ID: <Y+DlHUUMX6bACxA6@kuha.fi.intel.com> (raw)
In-Reply-To: <1675425314-13857-1-git-send-email-quic_linyyuan@quicinc.com>

On Fri, Feb 03, 2023 at 07:55:14PM +0800, Linyu Yuan wrote:
> there is no PM operation for a role switch device,
> call device_set_pm_not_required() in usb_role_switch_register() to disable.
> 
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> v2: remove cc stable
> 
>  drivers/usb/roles/class.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index eacb46e..b303c64 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -344,6 +344,7 @@ usb_role_switch_register(struct device *parent,
>  	dev_set_drvdata(&sw->dev, desc->driver_data);
>  	dev_set_name(&sw->dev, "%s-role-switch",
>  		     desc->name ? desc->name : dev_name(parent));
> +	device_set_pm_not_required(&sw->dev);
>  
>  	ret = device_register(&sw->dev);
>  	if (ret) {
> -- 
> 2.7.4

-- 
heikki

  reply	other threads:[~2023-02-06 11:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 11:55 [PATCH v2] usb: roles: disable pm for role switch device Linyu Yuan
2023-02-06 11:31 ` Heikki Krogerus [this message]
2023-02-07  7:41   ` Linyu Yuan
2023-02-07  7:48     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+DlHUUMX6bACxA6@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_linyyuan@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox