From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, Jack Pham <quic_jackp@quicinc.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Pratham Pratap <quic_ppratap@quicinc.com>
Subject: Re: [PATCH v2] usb: roles: disable pm for role switch device
Date: Tue, 7 Feb 2023 08:48:00 +0100 [thread overview]
Message-ID: <Y+ICMHZxz/32gGLk@kroah.com> (raw)
In-Reply-To: <ba912bbb-278e-f23d-ac2b-88958f7da491@quicinc.com>
On Tue, Feb 07, 2023 at 03:41:17PM +0800, Linyu Yuan wrote:
>
> On 2/6/2023 7:31 PM, Heikki Krogerus wrote:
> > On Fri, Feb 03, 2023 at 07:55:14PM +0800, Linyu Yuan wrote:
> > > there is no PM operation for a role switch device,
> > > call device_set_pm_not_required() in usb_role_switch_register() to disable.
> > >
> > > Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
>
> as discussion in Re: [PATCH] usb: typec: disable pm for typec class devices
> - Heikki Krogerus (kernel.org)
> <https://lore.kernel.org/linux-usb/Y+H+8Nt%2F5bgTBv4Y@kuha.fi.intel.com/> ,
>
>
> please don't merge this change after we have final solution with Heikki.
I will just drop this from my review queue. Please feel free to resend
it when you all have it worked out.
thanks,
greg k-h
prev parent reply other threads:[~2023-02-07 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 11:55 [PATCH v2] usb: roles: disable pm for role switch device Linyu Yuan
2023-02-06 11:31 ` Heikki Krogerus
2023-02-07 7:41 ` Linyu Yuan
2023-02-07 7:48 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+ICMHZxz/32gGLk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox