[PATCH v2] usb: roles: disable pm for role switch device

[PATCH v2] usb: roles: disable pm for role switch device

[Linyu Yuan]

there is no PM operation for a role switch device,
call device_set_pm_not_required() in usb_role_switch_register() to disable.

Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
---
v2: remove cc stable

 drivers/usb/roles/class.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index eacb46e..b303c64 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -344,6 +344,7 @@ usb_role_switch_register(struct device *parent,
 	dev_set_drvdata(&sw->dev, desc->driver_data);
 	dev_set_name(&sw->dev, "%s-role-switch",
 		     desc->name ? desc->name : dev_name(parent));
+	device_set_pm_not_required(&sw->dev);
 
 	ret = device_register(&sw->dev);
 	if (ret) {
-- 
2.7.4

Re: [PATCH v2] usb: roles: disable pm for role switch device

[Heikki Krogerus]

On Fri, Feb 03, 2023 at 07:55:14PM +0800, Linyu Yuan wrote:
> there is no PM operation for a role switch device,
> call device_set_pm_not_required() in usb_role_switch_register() to disable.
> 
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> v2: remove cc stable
> 
>  drivers/usb/roles/class.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index eacb46e..b303c64 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -344,6 +344,7 @@ usb_role_switch_register(struct device *parent,
>  	dev_set_drvdata(&sw->dev, desc->driver_data);
>  	dev_set_name(&sw->dev, "%s-role-switch",
>  		     desc->name ? desc->name : dev_name(parent));
> +	device_set_pm_not_required(&sw->dev);
>  
>  	ret = device_register(&sw->dev);
>  	if (ret) {
> -- 
> 2.7.4

-- 
heikki

Re: [PATCH v2] usb: roles: disable pm for role switch device

[Linyu Yuan]

On 2/6/2023 7:31 PM, Heikki Krogerus wrote:
> On Fri, Feb 03, 2023 at 07:55:14PM +0800, Linyu Yuan wrote:
>> there is no PM operation for a role switch device,
>> call device_set_pm_not_required() in usb_role_switch_register() to disable.
>>
>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


as discussion in Re: [PATCH] usb: typec: disable pm for typec class 
devices - Heikki Krogerus (kernel.org) 
<https://lore.kernel.org/linux-usb/Y+H+8Nt%2F5bgTBv4Y@kuha.fi.intel.com/> ,


please don't merge this change after we have final solution with Heikki.


>> ---
>> v2: remove cc stable
>>
>>   drivers/usb/roles/class.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
>> index eacb46e..b303c64 100644
>> --- a/drivers/usb/roles/class.c
>> +++ b/drivers/usb/roles/class.c
>> @@ -344,6 +344,7 @@ usb_role_switch_register(struct device *parent,
>>   	dev_set_drvdata(&sw->dev, desc->driver_data);
>>   	dev_set_name(&sw->dev, "%s-role-switch",
>>   		     desc->name ? desc->name : dev_name(parent));
>> +	device_set_pm_not_required(&sw->dev);
>>   
>>   	ret = device_register(&sw->dev);
>>   	if (ret) {
>> -- 
>> 2.7.4

Re: [PATCH v2] usb: roles: disable pm for role switch device

[Greg Kroah-Hartman]

On Tue, Feb 07, 2023 at 03:41:17PM +0800, Linyu Yuan wrote:
> 
> On 2/6/2023 7:31 PM, Heikki Krogerus wrote:
> > On Fri, Feb 03, 2023 at 07:55:14PM +0800, Linyu Yuan wrote:
> > > there is no PM operation for a role switch device,
> > > call device_set_pm_not_required() in usb_role_switch_register() to disable.
> > > 
> > > Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> 
> as discussion in Re: [PATCH] usb: typec: disable pm for typec class devices
> - Heikki Krogerus (kernel.org)
> <https://lore.kernel.org/linux-usb/Y+H+8Nt%2F5bgTBv4Y@kuha.fi.intel.com/> ,
> 
> 
> please don't merge this change after we have final solution with Heikki.

I will just drop this from my review queue.  Please feel free to resend
it when you all have it worked out.

thanks,

greg k-h