* [PATCH] usb: dwc2: add parenthess and space around *
@ 2021-03-29 3:31 Tian Tao
2021-03-29 5:06 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Tian Tao @ 2021-03-29 3:31 UTC (permalink / raw)
To: hminas; +Cc: linux-usb
Just fix the following checkpatch error:
ERROR: Macros with complex values should be enclosed in parentheses.`
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
---
drivers/usb/dwc2/hcd_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c
index 68bbac6..621a484 100644
--- a/drivers/usb/dwc2/hcd_queue.c
+++ b/drivers/usb/dwc2/hcd_queue.c
@@ -59,7 +59,7 @@
#define DWC2_UNRESERVE_DELAY (msecs_to_jiffies(5))
/* If we get a NAK, wait this long before retrying */
-#define DWC2_RETRY_WAIT_DELAY 1*1E6L
+#define DWC2_RETRY_WAIT_DELAY (1 * 1E6L)
/**
* dwc2_periodic_channel_available() - Checks that a channel is available for a
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc2: add parenthess and space around *
2021-03-29 3:31 [PATCH] usb: dwc2: add parenthess and space around * Tian Tao
@ 2021-03-29 5:06 ` Greg KH
2021-03-29 6:03 ` tiantao (H)
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-03-29 5:06 UTC (permalink / raw)
To: Tian Tao; +Cc: hminas, linux-usb
On Mon, Mar 29, 2021 at 11:31:45AM +0800, Tian Tao wrote:
> Just fix the following checkpatch error:
> ERROR: Macros with complex values should be enclosed in parentheses.`
Why the trailing ` character here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc2: add parenthess and space around *
2021-03-29 5:06 ` Greg KH
@ 2021-03-29 6:03 ` tiantao (H)
0 siblings, 0 replies; 3+ messages in thread
From: tiantao (H) @ 2021-03-29 6:03 UTC (permalink / raw)
To: Greg KH, Tian Tao; +Cc: hminas, linux-usb
在 2021/3/29 13:06, Greg KH 写道:
> On Mon, Mar 29, 2021 at 11:31:45AM +0800, Tian Tao wrote:
>> Just fix the following checkpatch error:
>> ERROR: Macros with complex values should be enclosed in parentheses.`
> Why the trailing ` character here?
thanks for review，This is mistake，I will send v2 to fix it.
>
> thanks,
>
> greg k-h
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-29 6:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-29 3:31 [PATCH] usb: dwc2: add parenthess and space around * Tian Tao
2021-03-29 5:06 ` Greg KH
2021-03-29 6:03 ` tiantao (H)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox