* [PATCH] usb: typec: silence a static checker warning
@ 2021-04-14 7:44 Dan Carpenter
2021-04-14 8:01 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-04-14 7:44 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, kernel-janitors
Smatch complains about a potential missing error code:
drivers/usb/typec/port-mapper.c:168 typec_link_port()
warn: missing error code 'ret'
This is a false positive and returning zero is intentional. Let's
re-arrange the code to silence the warning and make the intent more
clear.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/usb/typec/port-mapper.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/port-mapper.c b/drivers/usb/typec/port-mapper.c
index fae736eb0601..9b0991bdf391 100644
--- a/drivers/usb/typec/port-mapper.c
+++ b/drivers/usb/typec/port-mapper.c
@@ -157,15 +157,17 @@ int typec_link_port(struct device *port)
{
struct device *connector;
struct port_node *node;
- int ret = 0;
+ int ret;
node = create_port_node(port);
if (IS_ERR(node))
return PTR_ERR(node);
connector = find_connector(node);
- if (!connector)
+ if (!connector) {
+ ret = 0;
goto remove_node;
+ }
ret = link_port(to_typec_port(connector), node);
if (ret)
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: typec: silence a static checker warning
2021-04-14 7:44 [PATCH] usb: typec: silence a static checker warning Dan Carpenter
@ 2021-04-14 8:01 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2021-04-14 8:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, kernel-janitors
On Wed, Apr 14, 2021 at 10:44:40AM +0300, Dan Carpenter wrote:
> Smatch complains about a potential missing error code:
>
> drivers/usb/typec/port-mapper.c:168 typec_link_port()
> warn: missing error code 'ret'
>
> This is a false positive and returning zero is intentional. Let's
> re-arrange the code to silence the warning and make the intent more
> clear.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/port-mapper.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/port-mapper.c b/drivers/usb/typec/port-mapper.c
> index fae736eb0601..9b0991bdf391 100644
> --- a/drivers/usb/typec/port-mapper.c
> +++ b/drivers/usb/typec/port-mapper.c
> @@ -157,15 +157,17 @@ int typec_link_port(struct device *port)
> {
> struct device *connector;
> struct port_node *node;
> - int ret = 0;
> + int ret;
>
> node = create_port_node(port);
> if (IS_ERR(node))
> return PTR_ERR(node);
>
> connector = find_connector(node);
> - if (!connector)
> + if (!connector) {
> + ret = 0;
> goto remove_node;
> + }
>
> ret = link_port(to_typec_port(connector), node);
> if (ret)
> --
> 2.30.2
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-14 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-14 7:44 [PATCH] usb: typec: silence a static checker warning Dan Carpenter
2021-04-14 8:01 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox