Re: Confirmation for subscribe linux-usb

Re: Confirmation for subscribe linux-usb

[Greg KH]

On Wed, Aug 24, 2022 at 02:36:55PM +0800, Hu Xiaoying wrote:
> submit patch
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: Confirmation for subscribe linux-usb

[Greg KH]

On Wed, Aug 24, 2022 at 05:45:49PM +0800, Hu Xiaoying wrote:
> >From 040e7ed7e6e9ed850575ed075e02d960a5ffe191 Mon Sep 17 00:00:00 2001

Please stop and take a break for a day.

Look at the subject line of your email, is that what the other subject
lines for this mailing list look like?  You can see all of the prior
emails on the list on lore.kernel.org if you want some examples.

> From: Hu Xiaoying <huxiaoying@kylinos.cn>

Ok, but this does not match your signed-off-by line, as my bot told you
to fix, why not?

> Date: Wed, 22 Jun 2022 16:35:59 +0800
> Subject: [PATCH -next] KYLIN: usb: Improves USB2.0 write performance for
>  External HDD device (VID:PID = 0x0b05:0x1932)

That is a very long subject line, your editor told you to only use 50 or
so characters, please follow that rule.

> 
> CVE: NA

Why is this even here at all?  We don't track CVE numbers for kernel
patches, that's crazy and insane and even MITRE agrees that CVEs do not
make any sense at all for the Linux kernel.  So don't even attempt to
classify something as "no CVE here" as that makes no sense.

> 
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write  < 30MB/s.
> then, igoned to load module of uas for this device.
> ===============================================
> Write speed: Improves form 27MB/s to 40MB/s+

That seems very odd, what about the USB 3 connection for this device?
Why is UAS so slow for this specific device?

> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Hu Xiaoying <huxiaoying2008@gmail.cn>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h
> b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..abaf4ea8138b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -157,3 +157,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999,
>   "External HDD",
>   USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>   US_FL_ALWAYS_SYNC),
> +
> +/* Reported-by: Tom Hu <huxiaoying@kylinos.cn> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,

Why all versions?  Why not just your one specific one?

Also, your patch is corrupted and can not be applied at all :(

Please take a day off, relax, and come back in a few days and resubmit a
fixed up commit after reading our documentation for how to properly
write and submit a kernel change.

thanks,

greg k-h