Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] Revert "usb: xhci-pci: Set PROBE_PREFER_ASYNCHRONOUS"
Date: Thu, 30 Mar 2023 16:40:43 +0200	[thread overview]
Message-ID: <ZCWfa9Hqs_mF8GKh@kroah.com> (raw)
In-Reply-To: <20230330143056.1390020-3-mathias.nyman@linux.intel.com>

On Thu, Mar 30, 2023 at 05:30:55PM +0300, Mathias Nyman wrote:
> This reverts commit 4c2604a9a6899bab195edbee35fc8d64ce1444aa.
> 
> Asynch probe caused regression in a setup with both Renesas and Intel xHC
> controllers. Devices connected to the Renesas disconnected shortly after
> boot. With Asynch probe the busnumbers got interleaved.
> 
> xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 1
> xhci_hcd 0000:04:00.0: new USB bus registered, assigned bus number 2
> xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 3
> xhci_hcd 0000:04:00.0: new USB bus registered, assigned bus number 4
> 
> Reason why this commit causes regression is still unknown, but revert it
> while debugging the issue.
> 
> Link: https://lore.kernel.org/linux-usb/20230307132120.5897c5af@deangelis.fenrir.org.uk
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

I'll add a Fixes: and cc: stable on this, ok?

thanks,

greg k-h

  reply	other threads:[~2023-03-30 14:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 14:30 [PATCH 0/3] xhci fixes for usb-linus Mathias Nyman
2023-03-30 14:30 ` [PATCH 1/3] xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu Mathias Nyman
2023-03-30 14:40   ` Greg KH
2023-03-31  7:35     ` Mathias Nyman
2023-03-31  7:40       ` Greg KH
2023-03-30 14:30 ` [PATCH 2/3] Revert "usb: xhci-pci: Set PROBE_PREFER_ASYNCHRONOUS" Mathias Nyman
2023-03-30 14:40   ` Greg KH [this message]
2023-03-31  7:29     ` Mathias Nyman
2023-03-30 14:30 ` [PATCH 3/3] xhci: Free the command allocated for setting LPM if we return early Mathias Nyman
2023-04-03  7:17   ` Mirsad Goran Todorovac
2023-04-03  7:24     ` Greg KH
2023-04-03  7:57       ` Mirsad Goran Todorovac
2023-04-03  8:01         ` Mirsad Goran Todorovac
2023-04-03  8:28           ` Greg KH
2023-04-03  8:36             ` Mirsad Goran Todorovac
2023-04-03 12:33             ` Mirsad Goran Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCWfa9Hqs_mF8GKh@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox