From: Joe Perches <joe@perches.com>
To: sundar <prosunofficial@gmail.com>,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
neil.armstrong@linaro.org, dmitry.baryshkov@linaro.org,
u.kleine-koenig@pengutronix.de, christophe.jaillet@wanadoo.fr
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH v2] remove indentation for common path [linux-next]
Date: Sat, 20 Apr 2024 10:07:47 -0700 [thread overview]
Message-ID: <a51f703d4f8dc3b0917002c520ea6608ac642b75.camel@perches.com> (raw)
In-Reply-To: <20240420164927.15290-1-prosunofficial@gmail.com>
On Sat, 2024-04-20 at 22:19 +0530, sundar wrote:
> ```
Added check if pointer is null and removed indentation for common path
```
[]
> ```
diff --git a/drivers/usb/typec/mux/nb7vpq904m.c b/drivers/usb/typec/mux/nb7vpq904m.c
```
[]
> ```
@@ -321,35 +321,37 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7)
ep = of_graph_get_endpoint_by_regs(nb7->client->dev.of_node, 1, 0);
- if (ep) {
- ret = of_property_count_u32_elems(ep, "data-lanes");
- if (ret == -EINVAL)
- /* Property isn't here, consider default mapping */
- goto out_done;
- if (ret < 0)
- goto out_error;
-
- if (ret != DATA_LANES_COUNT) {
- dev_err(&nb7->client->dev, "expected 4 data lanes\n");
- ret = -EINVAL;
- goto out_error;
- }
+ if (!ep)
+ return 0;
```
Not equivalent code as the out_error:
of_node_put(ep);
isn't done
next prev parent reply other threads:[~2024-04-20 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 16:49 [PATCH v2] remove indentation for common path [linux-next] sundar
2024-04-20 17:07 ` Joe Perches [this message]
2024-04-21 0:43 ` sundar
2024-04-21 1:27 ` Joe Perches
2024-04-20 20:47 ` Dmitry Baryshkov
2024-04-21 0:52 ` sundar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a51f703d4f8dc3b0917002c520ea6608ac642b75.camel@perches.com \
--to=joe@perches.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=prosunofficial@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox