From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pengyu Luo <mitltlatltl@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Pavan Holla <pholla@chromium.org>,
Yue Haibing <yuehaibing@huawei.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency
Date: Thu, 4 Dec 2025 15:21:02 +0200 [thread overview]
Message-ID: <aTGKvnoMaUGAVhLH@kuha> (raw)
In-Reply-To: <20251204101111.1035975-1-arnd@kernel.org>
Thu, Dec 04, 2025 at 11:11:07AM +0100, Arnd Bergmann kirjoitti:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting DRM_AUX_HPD_BRIDGE is not possible from a built-in driver when
> CONFIG_DRM=m:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
> Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
> Selected by [y]:
> - UCSI_HUAWEI_GAOKUN [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_UCSI [=y] && EC_HUAWEI_GAOKUN [=y] && DRM_BRIDGE [=y] && OF [=y]
>
> Add the same dependency we have in similar drivers to work around this.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> index 7fcb1e1de5d6..b812be4d0e67 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -96,6 +96,7 @@ config UCSI_LENOVO_YOGA_C630
> config UCSI_HUAWEI_GAOKUN
> tristate "UCSI Interface Driver for Huawei Matebook E Go"
> depends on EC_HUAWEI_GAOKUN
> + depends on DRM || !DRM
> select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> help
> This driver enables UCSI support on the Huawei Matebook E Go tablet,
> --
> 2.39.5
--
heikki
prev parent reply other threads:[~2025-12-04 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 10:11 [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency Arnd Bergmann
2025-12-04 13:21 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTGKvnoMaUGAVhLH@kuha \
--to=heikki.krogerus@linux.intel.com \
--cc=abhishekpandit@chromium.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=pholla@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox